Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: base/android/java/src/org/chromium/base/metrics/RecordHistogram.java

Issue 1583233004: Measure time spent during StrictMode violations. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: SecureRandomInitializer.java Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/android/java/src/org/chromium/base/metrics/RecordHistogram.java
diff --git a/base/android/java/src/org/chromium/base/metrics/RecordHistogram.java b/base/android/java/src/org/chromium/base/metrics/RecordHistogram.java
index c1b04892e87362dfc459bcbacdb75d817f4fb975..f80aabe8ca6f14dd4cce02cf3b371d2f07e09129 100644
--- a/base/android/java/src/org/chromium/base/metrics/RecordHistogram.java
+++ b/base/android/java/src/org/chromium/base/metrics/RecordHistogram.java
@@ -18,6 +18,16 @@ import java.util.concurrent.TimeUnit;
*/
@JNINamespace("base::android")
public class RecordHistogram {
+ private static boolean sIsDisabledForTests = false;
+
+ /**
+ * Tests may not have native initialized, so they may need to disable metrics.
+ */
+ @VisibleForTesting
+ public static void disableForTests() {
+ sIsDisabledForTests = true;
+ }
+
/**
* Records a sample in a boolean UMA histogram of the given name. Boolean histogram has two
* buckets, corresponding to success (true) and failure (false). This is the Java equivalent of
@@ -26,6 +36,7 @@ public class RecordHistogram {
* @param sample sample to be recorded, either true or false
*/
public static void recordBooleanHistogram(String name, boolean sample) {
+ if (sIsDisabledForTests) return;
nativeRecordBooleanHistogram(name, System.identityHashCode(name), sample);
}
@@ -39,6 +50,7 @@ public class RecordHistogram {
* lower than |boundary|
*/
public static void recordEnumeratedHistogram(String name, int sample, int boundary) {
+ if (sIsDisabledForTests) return;
nativeRecordEnumeratedHistogram(name, System.identityHashCode(name), sample, boundary);
}
@@ -83,6 +95,7 @@ public class RecordHistogram {
*/
public static void recordCustomCountHistogram(
String name, int sample, int min, int max, int numBuckets) {
+ if (sIsDisabledForTests) return;
nativeRecordCustomCountHistogram(
name, System.identityHashCode(name), sample, min, max, numBuckets);
}
@@ -98,6 +111,7 @@ public class RecordHistogram {
*/
public static void recordLinearCountHistogram(
String name, int sample, int min, int max, int numBuckets) {
+ if (sIsDisabledForTests) return;
nativeRecordLinearCountHistogram(
name, System.identityHashCode(name), sample, min, max, numBuckets);
}
@@ -109,6 +123,7 @@ public class RecordHistogram {
* @param sample sample to be recorded, at least 0 and at most 100.
*/
public static void recordPercentageHistogram(String name, int sample) {
+ if (sIsDisabledForTests) return;
nativeRecordEnumeratedHistogram(name, System.identityHashCode(name), sample, 101);
}
@@ -119,6 +134,7 @@ public class RecordHistogram {
* values.
*/
public static void recordSparseSlowlyHistogram(String name, int sample) {
+ if (sIsDisabledForTests) return;
nativeRecordSparseHistogram(name, System.identityHashCode(name), sample);
}
@@ -176,6 +192,7 @@ public class RecordHistogram {
private static void recordCustomTimesHistogramMilliseconds(
String name, long duration, long min, long max, int numBuckets) {
+ if (sIsDisabledForTests) return;
nativeRecordCustomTimesHistogramMilliseconds(
name, System.identityHashCode(name), duration, min, max, numBuckets);
}
@@ -194,6 +211,7 @@ public class RecordHistogram {
* Initializes the metrics system.
*/
public static void initialize() {
+ if (sIsDisabledForTests) return;
nativeInitialize();
}

Powered by Google App Engine
This is Rietveld 408576698