Measure time spent during StrictMode violations.

chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser.webapps;
 
 import android.content.Intent;
 import android.graphics.Bitmap;
 import android.graphics.Color;
 import android.graphics.drawable.Drawable;
 import android.net.Uri;
 import android.os.Bundle;
 import android.os.StrictMode;
+import android.os.SystemClock;
 import android.text.TextUtils;
 import android.view.LayoutInflater;
 import android.view.View;
 import android.view.ViewGroup;
 import android.widget.FrameLayout;
 import android.widget.ImageView;
 import android.widget.TextView;
 
 import org.chromium.base.ActivityState;
 import org.chromium.base.ApiCompatibilityUtils;
 import org.chromium.base.ApplicationStatus;
 import org.chromium.base.Log;
 import org.chromium.base.StreamUtil;
 import org.chromium.base.VisibleForTesting;
+import org.chromium.base.metrics.RecordHistogram;
 import org.chromium.blink_public.platform.WebDisplayMode;
 import org.chromium.chrome.R;
 import org.chromium.chrome.browser.TabState;
 import org.chromium.chrome.browser.document.DocumentUtils;
 import org.chromium.chrome.browser.fullscreen.ChromeFullscreenManager;
 import org.chromium.chrome.browser.metrics.WebappUma;
 import org.chromium.chrome.browser.tab.EmptyTabObserver;
 import org.chromium.chrome.browser.tab.Tab;
 import org.chromium.chrome.browser.tab.TabDelegateFactory;
 import org.chromium.chrome.browser.tab.TabObserver;
 import org.chromium.chrome.browser.tab.TopControlsVisibilityDelegate;
 import org.chromium.chrome.browser.util.ColorUtils;
 import org.chromium.chrome.browser.util.UrlUtilities;
 import org.chromium.components.security_state.ConnectionSecurityLevel;
 import org.chromium.content.browser.ScreenOrientationProvider;
 import org.chromium.content_public.browser.LoadUrlParams;
 import org.chromium.net.NetworkChangeNotifier;
 import org.chromium.ui.base.PageTransition;
 
 import java.io.File;
 import java.io.FileNotFoundException;
 import java.io.FileOutputStream;
 import java.io.IOException;
+import java.util.concurrent.TimeUnit;
 
 /**
  * Displays a webapp in a nearly UI-less Chrome (InfoBars still appear).
  */
 public class WebappActivity extends FullScreenActivity {
     public static final String WEBAPP_SCHEME = "webapp";
 
     private static final String TAG = "WebappActivity";
     private static final long MS_BEFORE_NAVIGATING_BACK_FROM_INTERSTITIAL = 1000;
 
@@ skipping 101 matching lines @@
      * Saves the tab data out to a file.
      */
     void saveState(File activityDirectory) {
         File tabFile = getTabFile(activityDirectory, getActivityTab().getId());
 
         FileOutputStream foutput = null;
         // Temporarily allowing disk access while fixing. TODO: http://crbug.com/525781
         StrictMode.ThreadPolicy oldPolicy = StrictMode.allowThreadDiskReads();
         StrictMode.allowThreadDiskWrites();
         try {
+            long time = SystemClock.elapsedRealtime();
             foutput = new FileOutputStream(tabFile);
             TabState.saveState(foutput, getActivityTab().getState(), false);
+            RecordHistogram.recordTimesHistogram("Android.StrictMode.WebappSaveState",
+                    SystemClock.elapsedRealtime() - time, TimeUnit.MILLISECONDS);
         } catch (FileNotFoundException exception) {
             Log.e(TAG, "Failed to save out tab state.", exception);
         } catch (IOException exception) {
             Log.e(TAG, "Failed to save out tab state.", exception);
         } finally {
             StreamUtil.closeQuietly(foutput);
             StrictMode.setThreadPolicy(oldPolicy);
         }
     }
 
@@ skipping 98 matching lines @@
             int splashScreenIconType;
             if (splashImage == null) {
                 splashScreenIconType = WebappUma.SPLASHSCREEN_ICON_TYPE_FALLBACK;
             } else if (isUsingSmallSplashImage) {
                 splashScreenIconType = WebappUma.SPLASHSCREEN_ICON_TYPE_CUSTOM_SMALL;
             } else {
                 splashScreenIconType = WebappUma.SPLASHSCREEN_ICON_TYPE_CUSTOM;
             }
             mWebappUma.recordSplashscreenIconType(splashScreenIconType);
             mWebappUma.recordSplashscreenIconSize(
-                    Math.round((float) displayIcon.getWidth()

[Yaron, 2016/01/21 20:48:15]

was this removal intentional?

[Peter Wen, 2016/01/21 20:59:45]

Yeah, eclipse auto-removed it since density is a float already.

+                    Math.round(displayIcon.getWidth()
                             / getResources().getDisplayMetrics().density));
         }
 
         ViewGroup subLayout = (ViewGroup) LayoutInflater.from(WebappActivity.this)
                 .inflate(layoutId, mSplashScreen, true);
 
         // Set up the elements of the splash screen.
         TextView appNameView = (TextView) subLayout.findViewById(
                 R.id.webapp_splash_screen_name);
         ImageView splashIconView = (ImageView) subLayout.findViewById(
@@ skipping 260 matching lines @@
         return visible;
     }
 
     // We're temporarily disable CS on webapp since there are some issues. (http://crbug.com/471950)
     // TODO(changwan): re-enable it once the issues are resolved.
     @Override
     protected boolean isContextualSearchAllowed() {
         return false;
     }
 }