Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1583233002:
[cq] Automatically use the same bots for git cl try. (Closed)
|
Created:
4 years, 11 months ago by Michael Achenbach Modified:
4 years, 11 months ago CC:
v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[cq] Automatically use the same bots for git cl try.
Depot tools now uses the project's cq.cfg by default on
git cl try, if no other method is specified.
Based on:
https://codereview.chromium.org/1579423004/
https://codereview.chromium.org/1587893003/
BUG=chromium:565952
TBR=tandrii@chromium.org
LOG=n
NOTRY=true
Committed: https://crrev.com/45ec73da150e02fac1fc1dc15e3f14cb5bc2b45f
Cr-Commit-Position: refs/heads/master@{#33289}
Patch Set 1 #Patch Set 2 : presubmit #Messages
Total messages: 17 (10 generated)
Description was changed from ========== [cq] Automatically use the same bots for git cl try. BUG= ========== to ========== [cq] Automatically use the same bots for git cl try. Depot tools now uses the project's cq.cfg by default on git cl try, if no other method is specified. Based on: https://codereview.chromium.org/1579423004/ https://codereview.chromium.org/1587893003/ BUG=chromium:565952 LOG=n ==========
machenbach@chromium.org changed reviewers: + kjellander@chromium.org, tandrii@chromium.org
PTAL
Description was changed from ========== [cq] Automatically use the same bots for git cl try. Depot tools now uses the project's cq.cfg by default on git cl try, if no other method is specified. Based on: https://codereview.chromium.org/1579423004/ https://codereview.chromium.org/1587893003/ BUG=chromium:565952 LOG=n ========== to ========== [cq] Automatically use the same bots for git cl try. Depot tools now uses the project's cq.cfg by default on git cl try, if no other method is specified. Based on: https://codereview.chromium.org/1579423004/ https://codereview.chromium.org/1587893003/ BUG=chromium:565952 TBR=tandrii@chromium.org LOG=n ==========
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1583233002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1583233002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/9747)
lgtm
Description was changed from ========== [cq] Automatically use the same bots for git cl try. Depot tools now uses the project's cq.cfg by default on git cl try, if no other method is specified. Based on: https://codereview.chromium.org/1579423004/ https://codereview.chromium.org/1587893003/ BUG=chromium:565952 TBR=tandrii@chromium.org LOG=n ========== to ========== [cq] Automatically use the same bots for git cl try. Depot tools now uses the project's cq.cfg by default on git cl try, if no other method is specified. Based on: https://codereview.chromium.org/1579423004/ https://codereview.chromium.org/1587893003/ BUG=chromium:565952 TBR=tandrii@chromium.org LOG=n NOTRY=true ==========
The CQ bit was checked by machenbach@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from tandrii@chromium.org Link to the patchset: https://codereview.chromium.org/1583233002/#ps20001 (title: "presubmit")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1583233002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1583233002/20001
Message was sent while issue was closed.
Description was changed from ========== [cq] Automatically use the same bots for git cl try. Depot tools now uses the project's cq.cfg by default on git cl try, if no other method is specified. Based on: https://codereview.chromium.org/1579423004/ https://codereview.chromium.org/1587893003/ BUG=chromium:565952 TBR=tandrii@chromium.org LOG=n NOTRY=true ========== to ========== [cq] Automatically use the same bots for git cl try. Depot tools now uses the project's cq.cfg by default on git cl try, if no other method is specified. Based on: https://codereview.chromium.org/1579423004/ https://codereview.chromium.org/1587893003/ BUG=chromium:565952 TBR=tandrii@chromium.org LOG=n NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== [cq] Automatically use the same bots for git cl try. Depot tools now uses the project's cq.cfg by default on git cl try, if no other method is specified. Based on: https://codereview.chromium.org/1579423004/ https://codereview.chromium.org/1587893003/ BUG=chromium:565952 TBR=tandrii@chromium.org LOG=n NOTRY=true ========== to ========== [cq] Automatically use the same bots for git cl try. Depot tools now uses the project's cq.cfg by default on git cl try, if no other method is specified. Based on: https://codereview.chromium.org/1579423004/ https://codereview.chromium.org/1587893003/ BUG=chromium:565952 TBR=tandrii@chromium.org LOG=n NOTRY=true Committed: https://crrev.com/45ec73da150e02fac1fc1dc15e3f14cb5bc2b45f Cr-Commit-Position: refs/heads/master@{#33289} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/45ec73da150e02fac1fc1dc15e3f14cb5bc2b45f Cr-Commit-Position: refs/heads/master@{#33289} |
