Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(482)

Unified Diff: src/compiler/verifier.cc

Issue 1583213003: [turbofan] Fix bugs in escape analysis. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Unstage Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/pipeline.cc ('k') | test/unittests/compiler/escape-analysis-unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/verifier.cc
diff --git a/src/compiler/verifier.cc b/src/compiler/verifier.cc
index 84ae040bba48e5167d51c0723f99f96400db28c1..bbcdc933f95b8d5186f2fdf8a27e88c3284c33ef 100644
--- a/src/compiler/verifier.cc
+++ b/src/compiler/verifier.cc
@@ -428,13 +428,20 @@ void Verifier::Visitor::Check(Node* node) {
}
break;
}
- case IrOpcode::kFrameState:
+ case IrOpcode::kFrameState: {
// TODO(jarin): what are the constraints on these?
CHECK_EQ(5, value_count);
CHECK_EQ(0, control_count);
CHECK_EQ(0, effect_count);
CHECK_EQ(6, input_count);
+ for (int i = 0; i < 3; ++i) {
+ CHECK(NodeProperties::GetValueInput(node, i)->opcode() ==
+ IrOpcode::kStateValues ||
+ NodeProperties::GetValueInput(node, i)->opcode() ==
+ IrOpcode::kTypedStateValues);
+ }
break;
+ }
case IrOpcode::kStateValues:
case IrOpcode::kObjectState:
case IrOpcode::kTypedStateValues:
« no previous file with comments | « src/compiler/pipeline.cc ('k') | test/unittests/compiler/escape-analysis-unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698