Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Side by Side Diff: src/compiler/verifier.cc

Issue 1583213003: [turbofan] Fix bugs in escape analysis. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Unstage Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/compiler/pipeline.cc ('k') | test/unittests/compiler/escape-analysis-unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/compiler/verifier.h" 5 #include "src/compiler/verifier.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <deque> 8 #include <deque>
9 #include <queue> 9 #include <queue>
10 #include <sstream> 10 #include <sstream>
(...skipping 410 matching lines...) Expand 10 before | Expand all | Expand 10 after
421 break; 421 break;
422 case IrOpcode::kFinishRegion: { 422 case IrOpcode::kFinishRegion: {
423 // TODO(rossberg): what are the constraints on these? 423 // TODO(rossberg): what are the constraints on these?
424 // Type must be subsumed by input type. 424 // Type must be subsumed by input type.
425 if (typing == TYPED) { 425 if (typing == TYPED) {
426 Node* val = NodeProperties::GetValueInput(node, 0); 426 Node* val = NodeProperties::GetValueInput(node, 0);
427 CHECK(NodeProperties::GetType(val)->Is(NodeProperties::GetType(node))); 427 CHECK(NodeProperties::GetType(val)->Is(NodeProperties::GetType(node)));
428 } 428 }
429 break; 429 break;
430 } 430 }
431 case IrOpcode::kFrameState: 431 case IrOpcode::kFrameState: {
432 // TODO(jarin): what are the constraints on these? 432 // TODO(jarin): what are the constraints on these?
433 CHECK_EQ(5, value_count); 433 CHECK_EQ(5, value_count);
434 CHECK_EQ(0, control_count); 434 CHECK_EQ(0, control_count);
435 CHECK_EQ(0, effect_count); 435 CHECK_EQ(0, effect_count);
436 CHECK_EQ(6, input_count); 436 CHECK_EQ(6, input_count);
437 for (int i = 0; i < 3; ++i) {
438 CHECK(NodeProperties::GetValueInput(node, i)->opcode() ==
439 IrOpcode::kStateValues ||
440 NodeProperties::GetValueInput(node, i)->opcode() ==
441 IrOpcode::kTypedStateValues);
442 }
437 break; 443 break;
444 }
438 case IrOpcode::kStateValues: 445 case IrOpcode::kStateValues:
439 case IrOpcode::kObjectState: 446 case IrOpcode::kObjectState:
440 case IrOpcode::kTypedStateValues: 447 case IrOpcode::kTypedStateValues:
441 // TODO(jarin): what are the constraints on these? 448 // TODO(jarin): what are the constraints on these?
442 break; 449 break;
443 case IrOpcode::kCall: 450 case IrOpcode::kCall:
444 // TODO(rossberg): what are the constraints on these? 451 // TODO(rossberg): what are the constraints on these?
445 break; 452 break;
446 case IrOpcode::kTailCall: 453 case IrOpcode::kTailCall:
447 // TODO(bmeurer): what are the constraints on these? 454 // TODO(bmeurer): what are the constraints on these?
(...skipping 813 matching lines...) Expand 10 before | Expand all | Expand 10 after
1261 replacement->op()->EffectOutputCount() > 0); 1268 replacement->op()->EffectOutputCount() > 0);
1262 DCHECK(!NodeProperties::IsFrameStateEdge(edge) || 1269 DCHECK(!NodeProperties::IsFrameStateEdge(edge) ||
1263 replacement->opcode() == IrOpcode::kFrameState); 1270 replacement->opcode() == IrOpcode::kFrameState);
1264 } 1271 }
1265 1272
1266 #endif // DEBUG 1273 #endif // DEBUG
1267 1274
1268 } // namespace compiler 1275 } // namespace compiler
1269 } // namespace internal 1276 } // namespace internal
1270 } // namespace v8 1277 } // namespace v8
OLDNEW
« no previous file with comments | « src/compiler/pipeline.cc ('k') | test/unittests/compiler/escape-analysis-unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698