Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Issue 15832005: Make sure IfBuilder::Return clears the current block. (Closed)

Created:
7 years, 6 months ago by Michael Starzinger
Modified:
7 years, 6 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Make sure IfBuilder::Return clears the current block. This is a follow-up to an earlier bugfix. It doesn't yet trigger any known bugs but is a safety precaution since IfBuilder usage increases. R=jkummerow@chromium.org BUG=chromium:243868 Committed: http://code.google.com/p/v8/source/detail?r=14882

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M src/code-stubs-hydrogen.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/hydrogen.cc View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Michael Starzinger
7 years, 6 months ago (2013-05-29 12:33:30 UTC) #1
Jakob Kummerow
lgtm
7 years, 6 months ago (2013-05-29 12:35:06 UTC) #2
Michael Starzinger
7 years, 6 months ago (2013-05-29 12:36:48 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r14882 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698