Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Unified Diff: third_party/WebKit/Source/core/dom/IntersectionObservation.h

Issue 1583173002: Add virtual destructors to IntersectionObserverCallback (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/IntersectionObservation.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/dom/IntersectionObservation.h
diff --git a/third_party/WebKit/Source/core/dom/IntersectionObservation.h b/third_party/WebKit/Source/core/dom/IntersectionObservation.h
index 702882a74411ef3e1cf1163e0f82985a87d8314a..073631d427f1e77e31f65f51b6cd425a088ab08a 100644
--- a/third_party/WebKit/Source/core/dom/IntersectionObservation.h
+++ b/third_party/WebKit/Source/core/dom/IntersectionObservation.h
@@ -17,6 +17,7 @@ class Node;
class IntersectionObservation : public GarbageCollectedFinalized<IntersectionObservation> {
public:
IntersectionObservation(IntersectionObserver&, Element&, bool shouldReportRootBounds);
+ virtual ~IntersectionObservation();
dcheng 2016/01/14 07:06:09 No virtual needed here and on IntersectionObserver
sof 2016/01/14 07:13:09 Adding a TODO above this class decl, like TODO(O
haraken 2016/01/14 07:23:44 Yeah, makes sense. We considered to introduce Garb
szager1 2016/01/14 07:24:37 Done.
szager1 2016/01/14 07:24:37 Done.
struct IntersectionGeometry {
LayoutRect targetRect;
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/dom/IntersectionObservation.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698