Chromium Code Reviews| Index: third_party/WebKit/Source/core/dom/IntersectionObservation.h |
| diff --git a/third_party/WebKit/Source/core/dom/IntersectionObservation.h b/third_party/WebKit/Source/core/dom/IntersectionObservation.h |
| index 702882a74411ef3e1cf1163e0f82985a87d8314a..073631d427f1e77e31f65f51b6cd425a088ab08a 100644 |
| --- a/third_party/WebKit/Source/core/dom/IntersectionObservation.h |
| +++ b/third_party/WebKit/Source/core/dom/IntersectionObservation.h |
| @@ -17,6 +17,7 @@ class Node; |
| class IntersectionObservation : public GarbageCollectedFinalized<IntersectionObservation> { |
| public: |
| IntersectionObservation(IntersectionObserver&, Element&, bool shouldReportRootBounds); |
| + virtual ~IntersectionObservation(); |
|
dcheng
2016/01/14 07:06:09
No virtual needed here and on IntersectionObserver
sof
2016/01/14 07:13:09
Adding a TODO above this class decl, like
TODO(O
haraken
2016/01/14 07:23:44
Yeah, makes sense. We considered to introduce Garb
szager1
2016/01/14 07:24:37
Done.
szager1
2016/01/14 07:24:37
Done.
|
| struct IntersectionGeometry { |
| LayoutRect targetRect; |