Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(737)

Issue 158313002: Remove non-Aura stuff from InputMethodWin (Closed)

Created:
6 years, 10 months ago by yukawa
Modified:
6 years, 10 months ago
Reviewers:
Yuki
CC:
chromium-reviews, nona+watch_chromium.org, James Su, yukishiino+watch_chromium.org, penghuang+watch_chromium.org, yusukes+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Remove non-Aura stuff from InputMethodWin This CL removes obsolete code from InputMethodWin, which were used in pre-Aura era. BUG=330735, 319122 TEST=unit test Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=249992

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -16 lines) Patch
M ui/base/ime/input_method_win.cc View 1 chunk +0 lines, -16 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
yukawa
Could you take a look?
6 years, 10 months ago (2014-02-08 16:20:21 UTC) #1
Yuki
lgtm
6 years, 10 months ago (2014-02-08 17:03:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukawa@chromium.org/158313002/30001
6 years, 10 months ago (2014-02-08 17:04:13 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-08 18:09:22 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=260403
6 years, 10 months ago (2014-02-08 18:09:22 UTC) #5
yukawa
The CQ bit was checked by yukawa@chromium.org
6 years, 10 months ago (2014-02-09 06:56:59 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yukawa@chromium.org/158313002/30001
6 years, 10 months ago (2014-02-09 06:57:04 UTC) #7
commit-bot: I haz the power
6 years, 10 months ago (2014-02-09 10:44:34 UTC) #8
Message was sent while issue was closed.
Change committed as 249992

Powered by Google App Engine
This is Rietveld 408576698