third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp - Issue 1583103007: Use an up-to-date canvas size when building canvas filters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp

Issue 1583103007: Use an up-to-date canvas size when building canvas filters (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Remove unused function Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/svg/ReferenceFilterBuilder.cpp ('K') | « third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp

diff --git a/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp

index 71f1564cd33b96301deb0625dda26a6ea970a15e..09b50bd55b20c9c6ec8600f5ad7aa9873cad6896 100644

--- a/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp

+++ b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp

@@ -341,7 +341,7 @@ void CanvasRenderingContext2DState::resetTransform()

m_isTransformInvertible = true;

}

-SkImageFilter* CanvasRenderingContext2DState::getFilter(Element* styleResolutionHost, const Font& font) const

+SkImageFilter* CanvasRenderingContext2DState::getFilter(Element* styleResolutionHost, const Font& font, IntSize canvasSize) const

{

if (!m_filterValue)

return nullptr;

@@ -365,8 +365,9 @@ SkImageFilter* CanvasRenderingContext2DState::getFilter(Element* styleResolution

m_strokeStyle->applyToPaint(strokePaintForFilter);

fillPaintForFilter.setColor(m_fillStyle->paintColor());

strokePaintForFilter.setColor(m_strokeStyle->paintColor());

+ FloatSize floatCanvasSize(canvasSize);

const double effectiveZoom = 1.0; // Deliberately ignore zoom on the canvas element

- filterEffectBuilder->build(styleResolutionHost, filterStyle->filter(), effectiveZoom, &fillPaintForFilter, &strokePaintForFilter);

+ filterEffectBuilder->build(styleResolutionHost, filterStyle->filter(), effectiveZoom, &floatCanvasSize, &fillPaintForFilter, &strokePaintForFilter);

SkiaImageFilterBuilder imageFilterBuilder;

RefPtrWillBeRawPtr<FilterEffect> lastEffect = filterEffectBuilder->lastEffect();