Use an up-to-date canvas size when building canvas filters

third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2D.cpp

 /*
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2008, 2010 Nokia Corporation and/or its subsidiary(-ies)
  * Copyright (C) 2007 Alp Toker <alp@atoker.com>
  * Copyright (C) 2008 Eric Seidel <eric@webkit.org>
  * Copyright (C) 2008 Dirk Schulze <krit@webkit.org>
  * Copyright (C) 2010 Torch Mobile (Beijing) Co. Ltd. All rights reserved.
  * Copyright (C) 2012, 2013 Intel Corporation. All rights reserved.
  * Copyright (C) 2013 Adobe Systems Incorporated. All rights reserved.
  *
@@ skipping 858 matching lines @@
     c->restore();
     c->setMatrix(ctm);
 }
 
 template<typename DrawFunc, typename ContainsFunc>
 bool CanvasRenderingContext2D::draw(const DrawFunc& drawFunc, const ContainsFunc& drawCoversClipBounds, const SkRect& bounds, CanvasRenderingContext2DState::PaintType paintType, CanvasRenderingContext2DState::ImageType imageType)
 {
     if (!state().isTransformInvertible())
         return false;
 
+    // Filter construction can depend on the bounding box of the canvas' layout object,
+    // so we need layout to be up-to-date if filter construction is needed. However,
+    // layout can trigger scripts that cause the canvas to be freed, so we need to
+    // trigger layout before checking for the drawing canvas.
+    if (state().needsToBuildFilter())
+        canvas()->document().updateLayoutIgnorePendingStylesheets();

[Justin Novosad, 2016/01/15 21:16:28]

This is a big hammer that may affect performance if we call it when not
necessary. You can make the layout conditional on the canvas's style being
dirty. Basically you want to avoid recomputing style when the style recalc would
only affect objects that are not in the canvas's hierarchy. Use this instead:
canvas()->document().updateLayoutTreeForNodeIfNeeded(canvas());

[ajuma, 2016/01/18 14:34:15]

Turns out that updateLayoutTreeForNodeIfNeeded isn't sufficient (at least not
for the test case); document()->needsLayoutTreeUpdate() is false, so
updateLayoutTreeForNodeIfNeeded() earlies-out without doing any useful work. But
updateLayoutIgnorePendingStylesheets works because the FrameView needs layout
(since it hasn't done any layout yet -- FrameView::didFirstLayout is false at
this point), and the call to FrameView::layout leads to
FrameView::layoutFromRootObject which does layout on the whole tree.

Maybe a better approach is to pass the canvas rect directly to the filter
builder rather than having the builder retrieve the rect from the layout tree.
Let me see if that works.

+
     SkIRect clipBounds;
     if (!drawingCanvas() || !drawingCanvas()->getClipDeviceBounds(&clipBounds))
         return false;
 
     // If gradient size is zero, then paint nothing.
     CanvasStyle* style = state().style(paintType);
     if (style) {
         CanvasGradient* gradient = style->canvasGradient();
         if (gradient && gradient->gradient()->isZeroSize())
             return false;
@@ skipping 1439 matching lines @@
         if (imageType == CanvasRenderingContext2DState::NonOpaqueImage)
             return;
         if (alpha < 0xFF)
             return;
     }
 
     canvas()->buffer()->willOverwriteCanvas();
 }
 
 } // namespace blink