GN: Only honour system_libdir for target toolchain

GN: Only honour system_libdir for target toolchain

Without this change when system_libdir is set (e.g.
to lib64) it would apply this to all toolchains
including the host toolchain.

Committed: https://crrev.com/d4566597ab32adc5586831308625c0de954e4920
Cr-Commit-Position: refs/heads/master@{#371875}

[Sam Clegg, 2016-01-14 01:44:03]

Description was changed from

==========
GN: Only honour system_libdir for target toolchain
==========

to

==========
GN: Only honour system_libdir for target toolchain

Without this change when system_libdir is set (e.g.
to lib64) it would apply this to all toolchains
including the host toolchain.
==========

[Sam Clegg, 2016-01-14 01:44:03]

sbc@chromium.org changed reviewers:
+ rjkroege@chromium.org, thestig@chromium.org

[Sam Clegg, 2016-01-14 01:44:13]

sbc@chromium.org changed reviewers:
+ dpranke@chromium.org

[rjkroege, 2016-01-14 02:13:31]

On 2016/01/14 01:46:22, Sam Clegg wrote:

I verified for CrOS board specific GN builds (which is where system_libdir set
to lib64 is needed.) Thanks for writing.

LGTM

[Dirk Pranke, 2016-01-26 01:33:43]

I don't understand this change; why don't we want this to apply to the host
toolchains as well, since even those should also be using sysroots?

[rjkroege, 2016-01-26 01:46:52]

On 2016/01/26 01:33:43, Dirk Pranke wrote:
> I don't understand this change; why don't we want this to apply to the host
> toolchains as well, since even those should also be using sysroots?

The linux sysroots keep their pkgconfig in lib:

; find build/linux/* -name 'pkgcfind build/linux/* -name 'pkgconfig'
build/linux/debian_wheezy_amd64-sysroot/usr/lib/pkgconfig
build/linux/debian_wheezy_amd64-sysroot/usr/share/pkgconfig
build/linux/debian_wheezy_arm-sysroot/usr/lib/arm-linux-gnueabihf/pkgconfig
build/linux/debian_wheezy_arm-sysroot/usr/share/pkgconfig
build/linux/debian_wheezy_i386-sysroot/usr/lib/pkgconfig
build/linux/debian_wheezy_i386-sysroot/usr/share/pkgconfig

But CrOS x64 sysroots keep their pkgconfig in lib64:

; find auron_paine+7644.0.0+sysroot_chromeos-base_chromeos-chrome.tar.xz -name
pkgconfig
./auron_paine+7644.0.0+sysroot_chromeos-base_chromeos-chrome.tar.xz/usr/share/pkgconfig
./auron_paine+7644.0.0+sysroot_chromeos-base_chromeos-chrome.tar.xz/usr/lib64/pkgconfig

So: rather than changing all of the CrOS sysroots, this patch instead.

[Sam Clegg, 2016-01-26 01:47:49]

On 2016/01/26 01:33:43, Dirk Pranke wrote:
> I don't understand this change; why don't we want this to apply to the host
> toolchains as well, since even those should also be using sysroots?

The problem this change tries to solve is with the chromeOS builds.  Apparently
chromeos uses the system_libdir setting along with target_sysroot since their
64-bit libs are in 'lib64' rather than the default 'lib'.

However, the host toolchain have 'lib64' in it.

I think the reason this wasn't noticed in the gyp build is because the gyp build
just runs pkg-config just once, rather than once for each toolchain.

Perhaps we could rename 'system_libdir' to 'target_libdir' to make it clean that
it only applies to the target_sysroot?

[Sam Clegg, 2016-01-26 01:48:56]

On 2016/01/26 01:47:49, Sam Clegg wrote:
> On 2016/01/26 01:33:43, Dirk Pranke wrote:
> > I don't understand this change; why don't we want this to apply to the host
> > toolchains as well, since even those should also be using sysroots?
> 
> The problem this change tries to solve is with the chromeOS builds. 
Apparently
> chromeos uses the system_libdir setting along with target_sysroot since their
> 64-bit libs are in 'lib64' rather than the default 'lib'.
> 
> However, the host toolchain have 'lib64' in it.

That should have been "doesn't have".

> 
> I think the reason this wasn't noticed in the gyp build is because the gyp
build
> just runs pkg-config just once, rather than once for each toolchain.
> 
> Perhaps we could rename 'system_libdir' to 'target_libdir' to make it clean
that
> it only applies to the target_sysroot?

[Dirk Pranke, 2016-01-26 01:51:34]

Oh, got it, I hadn't properly absorbed/understood the earlier system_libdir
patch.

lgtm.

[Sam Clegg, 2016-01-27 20:50:27]

The CQ bit was checked by sbc@chromium.org

[commit-bot: I haz the power, 2016-01-27 20:51:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1583093002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1583093002/1

[commit-bot: I haz the power, 2016-01-27 21:36:33]

Description was changed from

==========
GN: Only honour system_libdir for target toolchain

Without this change when system_libdir is set (e.g.
to lib64) it would apply this to all toolchains
including the host toolchain.
==========

to

==========
GN: Only honour system_libdir for target toolchain

Without this change when system_libdir is set (e.g.
to lib64) it would apply this to all toolchains
including the host toolchain.
==========

[commit-bot: I haz the power, 2016-01-27 21:36:33]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-01-27 21:37:34]

Description was changed from

==========
GN: Only honour system_libdir for target toolchain

Without this change when system_libdir is set (e.g.
to lib64) it would apply this to all toolchains
including the host toolchain.
==========

to

==========
GN: Only honour system_libdir for target toolchain

Without this change when system_libdir is set (e.g.
to lib64) it would apply this to all toolchains
including the host toolchain.

Committed: https://crrev.com/d4566597ab32adc5586831308625c0de954e4920
Cr-Commit-Position: refs/heads/master@{#371875}
==========

[commit-bot: I haz the power, 2016-01-27 21:37:35]

Patchset 1 (id:??) landed as
https://crrev.com/d4566597ab32adc5586831308625c0de954e4920
Cr-Commit-Position: refs/heads/master@{#371875}