third_party/WebKit/Source/core/layout/LayoutFieldset.cpp - Issue 1583083003: Fieldset uses marginLeft for marginRight by mistake

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutFieldset.cpp

Issue 1583083003: Fieldset uses marginLeft for marginRight by mistake (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: modify test case Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/fast/forms/fieldset/legend-margin-with-float.html ('K') | « third_party/WebKit/LayoutTests/fast/forms/fieldset/legend-margin-with-float-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutFieldset.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutFieldset.cpp b/third_party/WebKit/Source/core/layout/LayoutFieldset.cpp

index 37750db20c649197de1de4147ee4cba6b0f52656..0674f56412c788d1a06a7cd7f77f07c3178756fb 100644

--- a/third_party/WebKit/Source/core/layout/LayoutFieldset.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutFieldset.cpp

@@ -46,7 +46,7 @@ void LayoutFieldset::computePreferredLogicalWidths()

int legendMinWidth = legend->minPreferredLogicalWidth();

Length legendMarginLeft = legend->style()->marginLeft();

- Length legendMarginRight = legend->style()->marginLeft();

+ Length legendMarginRight = legend->style()->marginRight();

if (legendMarginLeft.isFixed())

legendMinWidth += legendMarginLeft.value();