Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1583083003: Fieldset uses marginLeft for marginRight by mistake (Closed)

Created:
4 years, 11 months ago by Deokjin Kim
Modified:
4 years, 11 months ago
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fieldset uses marginLeft for marginRight by mistake BUG=498532 Committed: https://crrev.com/ef7ee132097748158460014e336036adddeec2a5 Cr-Commit-Position: refs/heads/master@{#370384}

Patch Set 1 #

Patch Set 2 : Add test case #

Patch Set 3 : modify test case #

Total comments: 3

Patch Set 4 : Modify test case's some parts commented by esprehn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/fast/forms/fieldset/legend-margin-with-float.html View 1 2 3 1 chunk +26 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/forms/fieldset/legend-margin-with-float-expected.txt View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFieldset.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (6 generated)
Deokjin Kim
PTAL.
4 years, 11 months ago (2016-01-14 13:10:28 UTC) #3
esprehn
This needs a test. I think it should be pretty easy to write a js-test ...
4 years, 11 months ago (2016-01-14 17:16:25 UTC) #4
esprehn
This needs a test. I think it should be pretty easy to write a js-test ...
4 years, 11 months ago (2016-01-14 17:16:26 UTC) #5
Deokjin Kim
On 2016/01/14 17:16:26, esprehn wrote: > This needs a test. I think it should be ...
4 years, 11 months ago (2016-01-14 23:55:06 UTC) #6
esprehn
On 2016/01/14 at 23:55:06, deokjin81.kim wrote: > On 2016/01/14 17:16:26, esprehn wrote: > > This ...
4 years, 11 months ago (2016-01-15 00:33:18 UTC) #7
Deokjin Kim
On 2016/01/15 00:33:18, esprehn wrote: > You need layout to require the logical width of ...
4 years, 11 months ago (2016-01-15 01:42:20 UTC) #8
esprehn
lgtm https://codereview.chromium.org/1583083003/diff/40001/third_party/WebKit/LayoutTests/fast/forms/fieldset/legend-margin-with-float.html File third_party/WebKit/LayoutTests/fast/forms/fieldset/legend-margin-with-float.html (right): https://codereview.chromium.org/1583083003/diff/40001/third_party/WebKit/LayoutTests/fast/forms/fieldset/legend-margin-with-float.html#newcode3 third_party/WebKit/LayoutTests/fast/forms/fieldset/legend-margin-with-float.html:3: <head> Leave out html, head https://codereview.chromium.org/1583083003/diff/40001/third_party/WebKit/LayoutTests/fast/forms/fieldset/legend-margin-with-float.html#newcode19 third_party/WebKit/LayoutTests/fast/forms/fieldset/legend-margin-with-float.html:19: <body> ...
4 years, 11 months ago (2016-01-20 08:59:57 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1583083003/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1583083003/60001
4 years, 11 months ago (2016-01-20 12:46:43 UTC) #12
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 11 months ago (2016-01-20 14:21:00 UTC) #14
commit-bot: I haz the power
4 years, 11 months ago (2016-01-20 14:21:44 UTC) #16
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/ef7ee132097748158460014e336036adddeec2a5
Cr-Commit-Position: refs/heads/master@{#370384}

Powered by Google App Engine
This is Rietveld 408576698