Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issue 1583063002: Snap the positioning area size (Closed)

Created:
4 years, 11 months ago by leviw_travelin_and_unemployed
Modified:
4 years, 11 months ago
Reviewers:
eae
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, slimming-paint-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Snap background image positioning area size https://codereview.chromium.org/1456813002 changed the way we handled background image positioning in the presence of sub-pixel values, but one value was left incorrectly unsnapped (positioning area), which could result in backgrounds being incorrectly positioned one pixel too far over, and in some cases clipped out entirely. BUG=570611 Committed: https://crrev.com/4c58d12a8d30864da67caf4377d2b41ff2996dc7 Cr-Commit-Position: refs/heads/master@{#369889}

Patch Set 1 #

Patch Set 2 : Add test. #

Patch Set 3 : ToT-ed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/backgrounds/background-with-sub-pixel-offset-positioning.html View 1 1 chunk +20 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/backgrounds/background-with-sub-pixel-offset-positioning-expected.html View 1 1 chunk +18 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BackgroundImageGeometry.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
leviw_travelin_and_unemployed
4 years, 11 months ago (2016-01-15 23:13:20 UTC) #3
eae
LGTM
4 years, 11 months ago (2016-01-15 23:26:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1583063002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1583063002/40001
4 years, 11 months ago (2016-01-15 23:43:39 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 11 months ago (2016-01-16 00:23:03 UTC) #7
commit-bot: I haz the power
4 years, 11 months ago (2016-01-16 00:23:50 UTC) #9
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4c58d12a8d30864da67caf4377d2b41ff2996dc7
Cr-Commit-Position: refs/heads/master@{#369889}

Powered by Google App Engine
This is Rietveld 408576698