Issue 1582993002: Use Document, rather than document element, for implicit root. - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(395)

My Issues | Starred Open | Closed | All

Issue 1582993002: Use Document, rather than document element, for implicit root. (Closed)

Created:
4 years, 11 months ago by szager1

Modified:
4 years, 11 months ago

Reviewers:
kinuko, ojan

CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis

Base URL:
https://chromium.googlesource.com/chromium/src@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Use Document, rather than document element, for implicit root. Re-landing after first attempt was reverted: https://codereview.chromium.org/1548523002/ TBR-ing, the only change is adding the missing visitor->trace(). BUG=570538 TBR=ojan@chromium.org,kinuko@chromium.org Committed: https://crrev.com/ffbee6c4d0eb8e80e741179c1c4b4f790a091ec8 Cr-Commit-Position: refs/heads/master@{#369351}

Patch Set 1 #

Created: 4 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+117 lines, -222 lines)			Patch
	M	third_party/WebKit/Source/core/core.gypi	View		2 chunks	+2 lines, -2 lines	0 comments	Download
	M	third_party/WebKit/Source/core/dom/Document.h	View		3 chunks	+3 lines, -0 lines	0 comments	Download
	M	third_party/WebKit/Source/core/dom/Document.cpp	View		4 chunks	+12 lines, -0 lines	0 comments	Download
	M	third_party/WebKit/Source/core/dom/Element.h	View		3 chunks	+3 lines, -3 lines	0 comments	Download
	M	third_party/WebKit/Source/core/dom/Element.cpp	View		3 chunks	+3 lines, -3 lines	0 comments	Download
	D	third_party/WebKit/Source/core/dom/ElementIntersectionObserverData.h	View		1 chunk	+0 lines, -49 lines	0 comments	Download
	D	third_party/WebKit/Source/core/dom/ElementIntersectionObserverData.cpp	View		1 chunk	+0 lines, -95 lines	0 comments	Download
	M	third_party/WebKit/Source/core/dom/ElementRareData.h	View		3 chunks	+5 lines, -5 lines	0 comments	Download
	M	third_party/WebKit/Source/core/dom/IntersectionObservation.h	View		3 chunks	+8 lines, -2 lines	0 comments	Download
	M	third_party/WebKit/Source/core/dom/IntersectionObservation.cpp	View		6 chunks	+13 lines, -8 lines	0 comments	Download
	M	third_party/WebKit/Source/core/dom/IntersectionObserver.h	View		2 chunks	+4 lines, -4 lines	0 comments	Download
	M	third_party/WebKit/Source/core/dom/IntersectionObserver.cpp	View		5 chunks	+23 lines, -16 lines	0 comments	Download
	M	third_party/WebKit/Source/core/dom/IntersectionObserverController.h	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	third_party/WebKit/Source/core/dom/IntersectionObserverController.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
	A +	third_party/WebKit/Source/core/dom/NodeIntersectionObserverData.h	View		1 chunk	+13 lines, -13 lines	0 comments	Download
	A +	third_party/WebKit/Source/core/dom/NodeIntersectionObserverData.cpp	View		4 chunks	+26 lines, -20 lines	0 comments	Download

Messages

Total messages: 14 (6 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1582993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1582993002/1

4 years, 11 months ago (2016-01-13 21:57:00 UTC) #2

commit-bot: I haz the power

Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_TIMED_OUT, no build URL) android_chromium_gn_compile_dbg on ...

4 years, 11 months ago (2016-01-14 00:08:00 UTC) #4

Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_TIMED_OUT, no
build URL)
  android_chromium_gn_compile_dbg on tryserver.chromium.android (JOB_TIMED_OUT,
no build URL)
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_TIMED_OUT,
no build URL)
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_TIMED_OUT, no
build URL)
  android_compile_dbg on tryserver.chromium.android (JOB_TIMED_OUT, no build
URL)
  cast_shell_android on tryserver.chromium.android (JOB_TIMED_OUT, no build URL)
  linux_android_rel_ng on tryserver.chromium.android (JOB_TIMED_OUT, no build
URL)
  cast_shell_linux on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromeos_daisy_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromeos_x86-generic_chromium_compile_only_ng on tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  chromium_presubmit on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL)
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux
(JOB_TIMED_OUT, no build URL)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_TIMED_OUT,
no build URL)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_TIMED_OUT, no
build URL)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build
URL)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build
URL)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)
  win_chromium_compile_dbg_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build
URL)
  win_chromium_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build URL)
  win_chromium_x64_rel_ng on tryserver.chromium.win (JOB_TIMED_OUT, no build
URL)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1582993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1582993002/1

4 years, 11 months ago (2016-01-14 00:47:29 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1582993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1582993002/1

4 years, 11 months ago (2016-01-14 05:13:38 UTC) #11

commit-bot: I haz the power

4 years, 11 months ago (2016-01-14 06:36:55 UTC) #14

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/ffbee6c4d0eb8e80e741179c1c4b4f790a091ec8
Cr-Commit-Position: refs/heads/master@{#369351}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Powered by Google App Engine

This is Rietveld 408576698