Add outline files for StylePropertyMap.

Add outline files for StylePropertyMap.

Spec: https://drafts.css-houdini.org/css-typed-om/#stylepropertymap

BUG=545318
Committed: https://crrev.com/000cd130f739fbeba6326c06941fb8b4207955b8
Cr-Commit-Position: refs/heads/master@{#370637}

[meade_UTC10, 2016-01-15 05:22:25]

meade@chromium.org changed reviewers:
+ timloh@chromium.org

[Timothy Loh, 2016-01-18 03:47:23]

https://codereview.chromium.org/1582963004/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/cssom/StylePropertyMap.cpp (right):

https://codereview.chromium.org/1582963004/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/cssom/StylePropertyMap.cpp:13: StyleValue*
StylePropertyMap::get(const String& propertyName)
Do these need to be virtual?

https://codereview.chromium.org/1582963004/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/cssom/StylePropertyMap.h (right):

https://codereview.chromium.org/1582963004/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/cssom/StylePropertyMap.h:45: class
CORE_EXPORT ImmutableStylePropertyMap : public StylePropertyMap {
Classes should be in their own files.

[meade_UTC10, 2016-01-19 00:15:20]

https://codereview.chromium.org/1582963004/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/cssom/StylePropertyMap.cpp (right):

https://codereview.chromium.org/1582963004/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/cssom/StylePropertyMap.cpp:13: StyleValue*
StylePropertyMap::get(const String& propertyName)
On 2016/01/18 03:47:23, Timothy Loh wrote:
> Do these need to be virtual?

I don't think so - The idea is that the CSSPropertyID versions are virtual, the
string ones just delegate to the PropertyID ones, so they shouldn't need to be
(and I've now updated the rest of the methods to follow this pattern). Is there
a usual convention for that kind of thing in blink?

https://codereview.chromium.org/1582963004/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/cssom/StylePropertyMap.h (right):

https://codereview.chromium.org/1582963004/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/cssom/StylePropertyMap.h:45: class
CORE_EXPORT ImmutableStylePropertyMap : public StylePropertyMap {
On 2016/01/18 03:47:23, Timothy Loh wrote:
> Classes should be in their own files.

Done.

[Timothy Loh, 2016-01-19 05:30:46]

FYI CSSPropertyID isn't enough to refer to a custom properties. IIRC
StylePropertySet uses some template stuff to handle those, you might need to do
something similar or come up with something better later on.

lgtm, but check with someone on bindings or oilpan about the
HeapVector<StyleValue*> thing

https://codereview.chromium.org/1582963004/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/css/cssom/StylePropertyMap.cpp (right):

https://codereview.chromium.org/1582963004/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/css/cssom/StylePropertyMap.cpp:13: StyleValue*
StylePropertyMap::get(const String& propertyName)
On 2016/01/19 00:15:19, Eddy wrote:
> On 2016/01/18 03:47:23, Timothy Loh wrote:
> > Do these need to be virtual?
> 
> I don't think so - The idea is that the CSSPropertyID versions are virtual,
the
> string ones just delegate to the PropertyID ones, so they shouldn't need to be
> (and I've now updated the rest of the methods to follow this pattern). Is
there
> a usual convention for that kind of thing in blink?

Latest patch seems fine for this.

https://codereview.chromium.org/1582963004/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/css/cssom/StylePropertyMap.h (right):

https://codereview.chromium.org/1582963004/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/cssom/StylePropertyMap.h:25:
HeapVector<StyleValue*> getAll(const String& propertyName);
Is the code generator expecting HeapVector<StyleValue*>? I think you're supposed
to use HeapVector<Member<T>> regardless of whether the vector is on the stack or
on the heap.

https://www.chromium.org/blink/blink-gc#TOC-Collections-and-ALLOW_ONLY_INLINE...
Component type should be Member<T> or WeakMember<T>.  Do not use T*.

https://codereview.chromium.org/1582963004/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/cssom/StylePropertyMap.h:46:
StylePropertyMap() {}
{ } is more common (at least be consistent with above)

https://codereview.chromium.org/1582963004/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/css/cssom/StylePropertyMap.idl (right):

https://codereview.chromium.org/1582963004/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/cssom/StylePropertyMap.idl:1: // Copyright
2015 The Chromium Authors. All rights reserved.
2016

[meade_UTC10, 2016-01-20 03:39:34]

https://codereview.chromium.org/1582963004/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/css/cssom/StylePropertyMap.h (right):

https://codereview.chromium.org/1582963004/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/cssom/StylePropertyMap.h:25:
HeapVector<StyleValue*> getAll(const String& propertyName);
On 2016/01/19 05:30:46, Timothy Loh wrote:
> Is the code generator expecting HeapVector<StyleValue*>? I think you're
supposed
> to use HeapVector<Member<T>> regardless of whether the vector is on the stack
or
> on the heap.
> 
>
https://www.chromium.org/blink/blink-gc#TOC-Collections-and-ALLOW_ONLY_INLINE...
> Component type should be Member<T> or WeakMember<T>.  Do not use T*.

Nope, it's not. I can't remember why I made it like this. Fixed.

https://codereview.chromium.org/1582963004/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/cssom/StylePropertyMap.h:46:
StylePropertyMap() {}
On 2016/01/19 05:30:46, Timothy Loh wrote:
> { } is more common (at least be consistent with above)

Done.

https://codereview.chromium.org/1582963004/diff/100001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/css/cssom/StylePropertyMap.idl (right):

https://codereview.chromium.org/1582963004/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/css/cssom/StylePropertyMap.idl:1: // Copyright
2015 The Chromium Authors. All rights reserved.
On 2016/01/19 05:30:46, Timothy Loh wrote:
> 2016

Done.

[meade_UTC10, 2016-01-20 05:25:29]

The CQ bit was checked by meade@chromium.org

[meade_UTC10, 2016-01-20 05:25:30]

The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org
Link to the patchset: https://codereview.chromium.org/1582963004/#ps120001
(title: "Change HeapVector<StyleValue*> to HeapVector<Member<StyleValue>>")

[commit-bot: I haz the power, 2016-01-20 05:26:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1582963004/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1582963004/120001

[commit-bot: I haz the power, 2016-01-20 06:03:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-01-20 06:03:23]

Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[meade_UTC10, 2016-01-21 04:56:48]

The CQ bit was checked by meade@chromium.org

[meade_UTC10, 2016-01-21 04:56:48]

The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org
Link to the patchset: https://codereview.chromium.org/1582963004/#ps160001
(title: "Update global-interface-listing-expected.html too")

[commit-bot: I haz the power, 2016-01-21 04:57:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1582963004/160001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1582963004/160001

[commit-bot: I haz the power, 2016-01-21 06:22:53]

Committed patchset #9 (id:160001)

[commit-bot: I haz the power, 2016-01-21 06:23:57]

Description was changed from

==========
Add outline files for StylePropertyMap.

Spec: https://drafts.css-houdini.org/css-typed-om/#stylepropertymap

BUG=545318
==========

to

==========
Add outline files for StylePropertyMap.

Spec: https://drafts.css-houdini.org/css-typed-om/#stylepropertymap

BUG=545318

Committed: https://crrev.com/000cd130f739fbeba6326c06941fb8b4207955b8
Cr-Commit-Position: refs/heads/master@{#370637}
==========

[commit-bot: I haz the power, 2016-01-21 06:23:58]

Patchset 9 (id:??) landed as
https://crrev.com/000cd130f739fbeba6326c06941fb8b4207955b8
Cr-Commit-Position: refs/heads/master@{#370637}