Fix some iterator invalidation issues while traversing CPDF_Dictionary.

core/include/fpdfapi/fpdf_objects.h

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #ifndef CORE_INCLUDE_FPDFAPI_FPDF_OBJECTS_H_
 #define CORE_INCLUDE_FPDFAPI_FPDF_OBJECTS_H_
 
 #include <map>
@@ skipping 367 matching lines @@
   CPDF_Array* GetArray(const CFX_ByteStringC& key) const;
 
   CFX_FloatRect GetRect(const CFX_ByteStringC& key) const;
 
   CFX_Matrix GetMatrix(const CFX_ByteStringC& key) const;
 
   FX_FLOAT GetFloat(const CFX_ByteStringC& key) const { return GetNumber(key); }
 
   FX_BOOL KeyExist(const CFX_ByteStringC& key) const;
 
+  // Set* functions invalidates iterators for the given key.

[Lei Zhang, 2016/01/14 01:32:29]

-> Set* functions invalidates iterators for |key|.

[Oliver Chang, 2016/01/14 02:04:53]

oops, I completely missed this comment, and made my own (similar) changes. do
they look OK?

   void SetAt(const CFX_ByteStringC& key, CPDF_Object* pObj);
 
   void SetAtName(const CFX_ByteStringC& key, const CFX_ByteString& name);
 
   void SetAtString(const CFX_ByteStringC& key, const CFX_ByteString& string);
 
   void SetAtInteger(const CFX_ByteStringC& key, int i);
 
   void SetAtNumber(const CFX_ByteStringC& key, FX_FLOAT f);
 
@@ skipping 10 matching lines @@
   void AddReference(const CFX_ByteStringC& key,
                     CPDF_IndirectObjectHolder* pDoc,
                     FX_DWORD objnum);
 
   void SetAtRect(const CFX_ByteStringC& key, const CFX_FloatRect& rect);
 
   void SetAtMatrix(const CFX_ByteStringC& key, const CFX_Matrix& matrix);
 
   void SetAtBoolean(const CFX_ByteStringC& key, FX_BOOL bValue);
 
+  // Invalidates iterators for the given key.
   void RemoveAt(const CFX_ByteStringC& key);
 
+  // Invalidates iterators for oldkey.
   void ReplaceKey(const CFX_ByteStringC& oldkey, const CFX_ByteStringC& newkey);
 
   FX_BOOL Identical(CPDF_Dictionary* pDict) const;
 
   size_t GetCount() const { return m_Map.size(); }
 
   iterator begin() { return m_Map.begin(); }
 
   iterator end() { return m_Map.end(); }
 
@@ skipping 166 matching lines @@
   iterator end() { return m_IndirectObjs.end(); }
   const_iterator end() const { return m_IndirectObjs.end(); }
 
  protected:
   CPDF_Parser* m_pParser;
   FX_DWORD m_LastObjNum;
   std::map<FX_DWORD, CPDF_Object*> m_IndirectObjs;
 };
 
 #endif  // CORE_INCLUDE_FPDFAPI_FPDF_OBJECTS_H_