Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4189)

Unified Diff: chrome/browser/resources/media_router/media_router.js

Issue 1582943003: [Media Router] Add cloud services preferences. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changes per anthonyvd@'s comments. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/media_router/media_router.js
diff --git a/chrome/browser/resources/media_router/media_router.js b/chrome/browser/resources/media_router/media_router.js
index f358ce789670cc811ef678f6225f072bb85aaf97..51a73d85cdce1d95ed3477879e25f61c89bb6bb6 100644
--- a/chrome/browser/resources/media_router/media_router.js
+++ b/chrome/browser/resources/media_router/media_router.js
@@ -80,9 +80,17 @@ cr.define('media_router', function() {
* Updates the preference that the user has seen the first run flow.
* Called when the user clicks on the acknowledgement button on the first run
* flow.
+ *
+ * @param {!Event} event
+ * Parameters in |event|.detail:
+ * optedIntoCloudServices - whether or not the user opted into cloud
+ * services.
*/
- function onAcknowledgeFirstRunFlow() {
- media_router.browserApi.acknowledgeFirstRunFlow();
+ function onAcknowledgeFirstRunFlow(event) {
+ var detail = event.detail;
+ /** @type {{optedIntoCloudServices: boolean}} */
imcheng 2016/01/25 19:21:06 move this line above "var detail = ..."
apacible 2016/01/26 01:12:56 Done.
+ media_router.browserApi.acknowledgeFirstRunFlow(
+ detail.optedIntoCloudServices);
}
/**

Powered by Google App Engine
This is Rietveld 408576698