[Media Router] Add cloud services preferences.

chrome/browser/resources/media_router/media_router_ui_interface.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // API invoked by the browser MediaRouterWebUIMessageHandler to communicate
 // with this UI.
 cr.define('media_router.ui', function() {
   'use strict';
 
   // The media-router-container element.
@@ skipping 36 matching lines @@
     container = mediaRouterContainer;
   }
 
   /**
    * Populates the WebUI with data obtained from Media Router.
    *
    * @param {{deviceMissingUrl: string,
    *          sinks: !Array<!media_router.Sink>,
    *          routes: !Array<!media_router.Route>,
    *          castModes: !Array<!media_router.CastMode>,
-   *          wasFirstRunFlowAcknowledged: boolean}} data
+   *          wasFirstRunFlowAcknowledged: boolean,
+   *          showFirstRunFlowCloudPref: boolean}} data

[imcheng, 2016/01/25 19:21:06]

Should this be {boolean|undefined}? Another way is to set it to false in
Chromium builds in MediaRouterWebUIMessageHandler. Also see comment below.

[apacible, 2016/01/26 01:12:56]

Done. Set to false in Chromium builds.

    * Parameters in data:
    *   deviceMissingUrl - url to be opened on "Device missing?" clicked.
    *   sinks - list of sinks to be displayed.
    *   routes - list of routes that are associated with the sinks.
    *   castModes - list of available cast modes.
    *   wasFirstRunFlowAcknowledged - true if first run flow was previously
    *       acknowledged by user.
+   *   showFirstRunFlowCloudPref - true if the cloud pref option should be
+   *       shown.
    */
   function setInitialData(data) {
     container.deviceMissingUrl = data['deviceMissingUrl'];
     container.castModeList = data['castModes'];
     container.allSinks = data['sinks'];
     container.routeList = data['routes'];
     container.showFirstRunFlow = !data['wasFirstRunFlowAcknowledged'];
+    container.showFirstRunFlowCloudPref =
+        data['showFirstRunFlowCloudPref'];

[imcheng, 2016/01/25 19:21:06]

should this be "data['showFirstRunFlowCloudPref'] || false" so it's not
undefined in Chromium builds?

[apacible, 2016/01/26 01:12:56]

See above comment.

     container.maybeShowRouteDetailsOnOpen();
     media_router.browserApi.onInitialDataReceived();
   }
 
   /**
    * Sets current issue to |issue|, or clears the current issue if |issue| is
    * null.
    *
    * @param {?media_router.Issue} issue
    */
@@ skipping 40 matching lines @@
     updateMaxHeight: updateMaxHeight,
   };
 });
 
 // API invoked by this UI to communicate with the browser WebUI message handler.
 cr.define('media_router.browserApi', function() {
   'use strict';
 
   /**
    * Indicates that the user has acknowledged the first run flow.
+   *
+   * @param {boolean} optedIntoCloudServices Whether or not the user opted into
+   *                  cloud services.
    */
-  function acknowledgeFirstRunFlow() {
-    chrome.send('acknowledgeFirstRunFlow');
+  function acknowledgeFirstRunFlow(optedIntoCloudServices) {
+    chrome.send('acknowledgeFirstRunFlow', [optedIntoCloudServices]);
   }
 
   /**
    * Acts on the given issue.
    *
    * @param {string} issueId
    * @param {number} actionType Type of action that the user clicked.
    * @param {?number} helpPageId The numeric help center ID.
    */
   function actOnIssue(issueId, actionType, helpPageId) {
@@ skipping 139 matching lines @@
     reportInitialState: reportInitialState,
     reportNavigateToView: reportNavigateToView,
     reportSelectedCastMode: reportSelectedCastMode,
     reportSinkCount: reportSinkCount,
     reportTimeToClickSink: reportTimeToClickSink,
     reportTimeToInitialActionClose: reportTimeToInitialActionClose,
     requestInitialData: requestInitialData,
     requestRoute: requestRoute,
   };
 });