Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 1582903004: Fix another invalidated iterator issue while traversing CPDF_Dictionary. (Closed)

Created:
4 years, 11 months ago by Oliver Chang
Modified:
4 years, 11 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix another invalidated iterator issue while traversing CPDF_Dictionary. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/8694bf8ac331d9a94d62d86465d599eee54486d0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M core/src/fpdfdoc/doc_formcontrol.cpp View 1 chunk +5 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Oliver Chang
ptal, my bad for not noticing this in the map conversion CL.
4 years, 11 months ago (2016-01-14 05:28:34 UTC) #1
Lei Zhang
lgtm Now we know where we don't have test coverage.
4 years, 11 months ago (2016-01-14 05:41:48 UTC) #2
Oliver Chang
4 years, 11 months ago (2016-01-14 05:49:27 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8694bf8ac331d9a94d62d86465d599eee54486d0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698