pkg/dart_messages/bin/message_id.dart - Issue 1582903003: Generate dart2js and analyzer files for shared messages.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/dart_messages/bin/message_id.dart

Issue 1582903003: Generate dart2js and analyzer files for shared messages. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Address comments (and rebase) Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/dart_messages/bin/message_id.dart

diff --git a/pkg/dart_messages/bin/message_id.dart b/pkg/dart_messages/bin/message_id.dart

index 2d7ed5387cfb9c349b1b6f4e82d91fe8384c8eb7..f94b384c01839328ad9a690c6173dadf27991673 100644

--- a/pkg/dart_messages/bin/message_id.dart

+++ b/pkg/dart_messages/bin/message_id.dart

@@ -23,7 +23,7 @@ String computeId() {

/// Computes a random message ID that hasn't been used before.

void main() {

var usedIds =

- shared_messages.MESSAGES.values.map((entry) => entry['id']).toSet();

+ shared_messages.MESSAGES.values.map((entry) => entry.id).toSet();

print("${usedIds.length} existing ids");

« no previous file with comments | « pkg/dart_messages/bin/json_converter.dart ('k') | pkg/dart_messages/bin/publish.dart » ('j') | no next file with comments »