pkg/dart_messages/lib/shared_messages.json - Issue 1582903003: Generate dart2js and analyzer files for shared messages.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: pkg/dart_messages/lib/shared_messages.json

Issue 1582903003: Generate dart2js and analyzer files for shared messages. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: remove dead code and add todo instead. Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 {}	1 {"exampleMessage":{"id":"use an Id generated by bin/message_id.dart","template": "#use #named #arguments","howToFix":"an explanation on how to fix things"}}
	Siggi Cherem (dart-lang) 2016/01/14 17:57:40 Up to yoU: - consider moving this under a generat Up to yoU: - consider moving this under a generated folder? - consider adding an AUTOGENERATED comment? I know JSON doesn't let you put comments that easily. One option would be to add a bogus entry. For example: [" / AUTOGENERATED --- this file was generated by `bin/publish.dart` / ", {"exampleMessage":{....}}) Or to add a line with an arbitraty format, but skip it before parsing in your tools. floitsch 2016/01/15 17:20:39 Moved, but didn't add auto-generated notice. It's Show quoted text On 2016/01/14 17:57:40, Siggi Cherem (dart-lang) wrote: > Up to yoU: > - consider moving this under a generated folder? > - consider adding an AUTOGENERATED comment? > > I know JSON doesn't let you put comments that easily. One option would be to add > a bogus entry. For example: > [" / AUTOGENERATED --- this file was generated by `bin/publish.dart` / ", > {"exampleMessage":{....}}) > > Or to add a line with an arbitraty format, but skip it before parsing in your > tools. Moved, but didn't add auto-generated notice. It's one long line of JSON, which is very uninviting to edit.
OLD	NEW