Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(191)

Issue 1582843003: Move SafeBrowsing trace events to the loader category (Closed)

Created:
4 years, 11 months ago by Joe Mason
Modified:
4 years, 11 months ago
CC:
chromium-reviews, grt+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move SafeBrowsing trace events to the loader category BUG=576750 Committed: https://crrev.com/81ebeb8adecb5d85610dbbc40bf07fcc7d83c9d9 Cr-Commit-Position: refs/heads/master@{#369352}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/renderer_host/safe_browsing_resource_throttle.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/safe_browsing_db/util.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (5 generated)
Joe Mason
The tracing team has asked me to stick to existing trace groups, and we agreed ...
4 years, 11 months ago (2016-01-14 01:31:24 UTC) #1
Joe Mason
Argh, forgot to click "add reviewers"
4 years, 11 months ago (2016-01-14 01:32:07 UTC) #3
Lei Zhang
lgtm
4 years, 11 months ago (2016-01-14 01:33:44 UTC) #4
Nathan Parker
lgtm
4 years, 11 months ago (2016-01-14 02:07:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1582843003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1582843003/1
4 years, 11 months ago (2016-01-14 03:38:10 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_TIMED_OUT, no build URL) android_chromium_gn_compile_dbg on ...
4 years, 11 months ago (2016-01-14 05:41:56 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1582843003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1582843003/1
4 years, 11 months ago (2016-01-14 06:25:10 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-14 06:40:45 UTC) #12
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 06:41:59 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/81ebeb8adecb5d85610dbbc40bf07fcc7d83c9d9
Cr-Commit-Position: refs/heads/master@{#369352}

Powered by Google App Engine
This is Rietveld 408576698