Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 1582793008: Fix I420ToNV21 for wrong dst_stride_y parameter. (Closed)

Created:
4 years, 11 months ago by fbarchard1
Modified:
4 years, 11 months ago
Reviewers:
harryjin, Diony Rosa
Base URL:
https://chromium.googlesource.com/libyuv/libyuv@master
Target Ref:
refs/heads/master
Project:
libyuv
Visibility:
Public.

Description

Fix I420ToNV21 for wrong dst_stride_y parameter. I420ToNV21 passes the wrong dst_stride_y when it calls I420ToNV12; parameter 8 (convert_from.cc:448) is src_stride_y but should be dst_stride_y. This causes image corruption when converting I420 -> NV21 with mismatched luminance strides. R=dhrosa@google.com, harryjin@google.com BUG=libyuv:547 Committed: https://chromium.googlesource.com/libyuv/libyuv/+/8377c798fb50ba438fb4ec136ea414f33eb0cfcf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M README.chromium View 1 chunk +1 line, -1 line 0 comments Download
M include/libyuv/version.h View 1 chunk +1 line, -1 line 0 comments Download
M source/convert_from.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
fbarchard1
4 years, 11 months ago (2016-01-15 00:12:11 UTC) #1
Diony Rosa
lgtm oops :)
4 years, 11 months ago (2016-01-15 01:23:25 UTC) #3
fbarchard1
4 years, 11 months ago (2016-01-15 01:38:59 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8377c798fb50ba438fb4ec136ea414f33eb0cfcf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698