[es6] add SetFunctionName() behaviour to AssignmentExpression

[es6] add SetFunctionName() behaviour to AssignmentExpression

BUG=v8:3699
LOG=N
R=adamk@chromium.org, rossberg@chromium.org, littledan@chromium.org

Committed: https://crrev.com/2a20d5183795da933c1df46d95fc60692b123879
Cr-Commit-Position: refs/heads/master@{#33276}

[caitp (gmail), 2016-01-13 22:26:43]

Adds AssignmentExpression name inference, and some simple tests

[adamk, 2016-01-13 22:45:09]

lgtm with a few more tests

https://codereview.chromium.org/1582783004/diff/1/test/mjsunit/harmony/functi...
File test/mjsunit/harmony/function-name.js (right):

https://codereview.chromium.org/1582783004/diff/1/test/mjsunit/harmony/functi...
test/mjsunit/harmony/function-name.js:128: basicFn = function() { return true;
};
Please also add a case where the function has a name (and show that it's not
overwritten).

https://codereview.chromium.org/1582783004/diff/1/test/mjsunit/harmony/functi...
test/mjsunit/harmony/function-name.js:143: classLit = class { constructor() {}
};
Can you also add a case where the class is named, and one where it has a static
"name" method?

[caitp (gmail), 2016-01-13 22:53:46]

https://codereview.chromium.org/1582783004/diff/1/test/mjsunit/harmony/functi...
File test/mjsunit/harmony/function-name.js (right):

https://codereview.chromium.org/1582783004/diff/1/test/mjsunit/harmony/functi...
test/mjsunit/harmony/function-name.js:128: basicFn = function() { return true;
};
On 2016/01/13 22:45:09, adamk wrote:
> Please also add a case where the function has a name (and show that it's not
> overwritten).

Done.

https://codereview.chromium.org/1582783004/diff/1/test/mjsunit/harmony/functi...
test/mjsunit/harmony/function-name.js:143: classLit = class { constructor() {}
};
On 2016/01/13 22:45:09, adamk wrote:
> Can you also add a case where the class is named, and one where it has a
static
> "name" method?

Done.

[adamk, 2016-01-13 22:54:22]

thanks, still lgtm

[caitp (gmail), 2016-01-13 23:10:23]

The CQ bit was checked by caitpotter88@gmail.com

[commit-bot: I haz the power, 2016-01-13 23:10:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1582783004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1582783004/20001

[commit-bot: I haz the power, 2016-01-13 23:35:39]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-01-13 23:36:14]

Description was changed from

==========
[es6] add SetFunctionName() behaviour to AssignmentExpression

BUG=v8:3699
LOG=N
R=adamk@chromium.org, rossberg@chromium.org, littledan@chromium.org
==========

to

==========
[es6] add SetFunctionName() behaviour to AssignmentExpression

BUG=v8:3699
LOG=N
R=adamk@chromium.org, rossberg@chromium.org, littledan@chromium.org

Committed: https://crrev.com/2a20d5183795da933c1df46d95fc60692b123879
Cr-Commit-Position: refs/heads/master@{#33276}
==========

[commit-bot: I haz the power, 2016-01-13 23:36:15]

Patchset 2 (id:??) landed as
https://crrev.com/2a20d5183795da933c1df46d95fc60692b123879
Cr-Commit-Position: refs/heads/master@{#33276}

[rossberg, 2016-01-14 08:01:53]

https://codereview.chromium.org/1582783004/diff/20001/test/mjsunit/harmony/fu...
File test/mjsunit/harmony/function-name.js (right):

https://codereview.chromium.org/1582783004/diff/20001/test/mjsunit/harmony/fu...
test/mjsunit/harmony/function-name.js:125: (function testAssignment() {
This could take a couple more tests. In particular, cases where name shall not
be set, e.g.:

dontSet = [function(){}][0];
assertEquals(undefined, dontSet.name);

etc.