Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Side by Side Diff: content/renderer/render_view_browsertest.cc

Issue 15827007: Disable RenderViewImpltest.InsertCharacters (flaky on XP) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix test name Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/basictypes.h" 5 #include "base/basictypes.h"
6 6
7 #include "base/shared_memory.h" 7 #include "base/shared_memory.h"
8 #include "base/string_util.h" 8 #include "base/string_util.h"
9 #include "base/utf_string_conversions.h" 9 #include "base/utf_string_conversions.h"
10 #include "content/common/view_messages.h" 10 #include "content/common/view_messages.h"
(...skipping 1164 matching lines...) Expand 10 before | Expand all | Expand 10 after
1175 } 1175 }
1176 #else 1176 #else
1177 NOTIMPLEMENTED(); 1177 NOTIMPLEMENTED();
1178 #endif 1178 #endif
1179 } 1179 }
1180 1180
1181 // Test that our EditorClientImpl class can insert characters when we send 1181 // Test that our EditorClientImpl class can insert characters when we send
1182 // keyboard events through the RenderWidget::OnHandleInputEvent() function. 1182 // keyboard events through the RenderWidget::OnHandleInputEvent() function.
1183 // This test is for preventing regressions caused only when we use non-US 1183 // This test is for preventing regressions caused only when we use non-US
1184 // keyboards, such as Issue 10846. 1184 // keyboards, such as Issue 10846.
1185 TEST_F(RenderViewImplTest, InsertCharacters) { 1185 // see http://crbug.com/244562
1186 #if defined(OS_WIN)
1187 #define MAYBE_InsertCharacters DISABLED_InsertCharacters
1188 #else
1189 #define MAYBE_InsertCharacters InsertCharacters
1190 #endif
1191 TEST_F(RenderViewImplTest, MAYBE_InsertCharacters) {
1186 #if !defined(OS_MACOSX) 1192 #if !defined(OS_MACOSX)
1187 static const struct { 1193 static const struct {
1188 MockKeyboard::Layout layout; 1194 MockKeyboard::Layout layout;
1189 const wchar_t* expected_result; 1195 const wchar_t* expected_result;
1190 } kLayouts[] = { 1196 } kLayouts[] = {
1191 #if 0 1197 #if 0
1192 // Disabled these keyboard layouts because buildbots do not have their 1198 // Disabled these keyboard layouts because buildbots do not have their
1193 // keyboard-layout drivers installed. 1199 // keyboard-layout drivers installed.
1194 {MockKeyboard::LAYOUT_ARABIC, 1200 {MockKeyboard::LAYOUT_ARABIC,
1195 L"\x0030\x0031\x0032\x0033\x0034\x0035\x0036\x0037" 1201 L"\x0030\x0031\x0032\x0033\x0034\x0035\x0036\x0037"
(...skipping 653 matching lines...) Expand 10 before | Expand all | Expand 10 after
1849 1855
1850 // Copy the document content to std::wstring and compare with the 1856 // Copy the document content to std::wstring and compare with the
1851 // expected result. 1857 // expected result.
1852 const int kMaxOutputCharacters = 256; 1858 const int kMaxOutputCharacters = 256;
1853 std::wstring output = UTF16ToWideHack( 1859 std::wstring output = UTF16ToWideHack(
1854 GetMainFrame()->contentAsText(kMaxOutputCharacters)); 1860 GetMainFrame()->contentAsText(kMaxOutputCharacters));
1855 EXPECT_EQ(output, L"hello \n\nworld"); 1861 EXPECT_EQ(output, L"hello \n\nworld");
1856 } 1862 }
1857 1863
1858 } // namespace content 1864 } // namespace content
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698