runtime/vm/intermediate_language_ia32.cc - Issue 15827006: Implement shift left on ARM and re-enable previously disabled test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/intermediate_language_ia32.cc

Issue 15827006: Implement shift left on ARM and re-enable previously disabled test. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/intermediate_language_ia32.cc

===================================================================

--- runtime/vm/intermediate_language_ia32.cc (revision 23306)

+++ runtime/vm/intermediate_language_ia32.cc (working copy)

@@ -2198,11 +2198,7 @@

__ j(NEGATIVE, deopt);

return;

}

- intptr_t tmp = (left_int > 0) ? left_int : ~left_int;

- intptr_t max_right = kSmiBits;

- while ((tmp >>= 1) != 0) {

- max_right--;

- }

+ const intptr_t max_right = kSmiBits - Utils::HighestBit(left_int);

const bool right_needs_check =

(right_range == NULL) ||

!right_range->IsWithin(0, max_right - 1);

« no previous file with comments | « runtime/vm/intermediate_language_arm.cc ('k') | runtime/vm/intermediate_language_x64.cc » ('j') | no next file with comments »