Fall back to inlining intervals to generate stack traces in --noopt. Inlined frames will lack line …

Fall back to inlining intervals to generate stack traces in --noopt. Inlined frames will lack line and column positions, but they will at least be expanded.

Fix stack traces when visible functions are inlined into an invisible function.

Fix off-by-one expanding inlined functions in the profiler.

BUG=http://dartbug.com/24783
R=johnmccutchan@google.com

Committed: https://github.com/dart-lang/sdk/commit/80702cb2722f70906d4f2c5a32b0e2a14ad8aa20

[rmacnak, 2016-01-12 22:08:56]

Description was changed from

==========
Fall back to inlining intervals to generate stack traces in --noopt. Inlined
frames will lack line and column positions, but they will at least be expanded.

Fix stack traces when visible functions are inlined into an invisible
function.

Fix off-by-one expanding inlined functions in the profiler.
==========

to

==========
Fall back to inlining intervals to generate stack traces in --noopt. Inlined
frames will lack line and column positions, but they will at least be expanded.

Fix stack traces when visible functions are inlined into an invisible
function.

Fix off-by-one expanding inlined functions in the profiler.

BUG=http://dartbug.com/24783
==========

[rmacnak, 2016-01-12 22:09:35]

Description was changed from

==========
Fall back to inlining intervals to generate stack traces in --noopt. Inlined
frames will lack line and column positions, but they will at least be expanded.

Fix stack traces when visible functions are inlined into an invisible
function.

Fix off-by-one expanding inlined functions in the profiler.

BUG=http://dartbug.com/24783
==========

to

==========
Fall back to inlining intervals to generate stack traces in --noopt. Inlined
frames will lack line and column positions, but they will at least be expanded.

Fix stack traces when visible functions are inlined into an invisible function.

Fix off-by-one expanding inlined functions in the profiler.

BUG=http://dartbug.com/24783
==========

[rmacnak, 2016-01-12 22:18:36]

rmacnak@google.com changed reviewers:
+ johnmccutchan@google.com

[Cutch, 2016-01-12 22:27:50]

LGTM with some comments/suggestions

https://codereview.chromium.org/1582683003/diff/1/runtime/vm/profiler_test.cc
File runtime/vm/profiler_test.cc (right):

https://codereview.chromium.org/1582683003/diff/1/runtime/vm/profiler_test.cc...
runtime/vm/profiler_test.cc:1414: TEST_CASE(Profiler_InliningIntervalBoundry) {
Add a comment here and point out the code in profiler_service.cc that is needed
to make this test pass.

https://codereview.chromium.org/1582683003/diff/1/runtime/vm/profiler_test.cc...
runtime/vm/profiler_test.cc:1451: FLAG_background_compilation = false;
Might want to introduce a Scope object like DisableNativeProfileScope above for
swapping this flag.

[rmacnak, 2016-01-13 00:40:49]

https://codereview.chromium.org/1582683003/diff/1/runtime/vm/profiler_test.cc
File runtime/vm/profiler_test.cc (right):

https://codereview.chromium.org/1582683003/diff/1/runtime/vm/profiler_test.cc...
runtime/vm/profiler_test.cc:1414: TEST_CASE(Profiler_InliningIntervalBoundry) {
On 2016/01/12 22:27:50, Cutch wrote:
> Add a comment here and point out the code in profiler_service.cc that is
needed
> to make this test pass.

Done.

https://codereview.chromium.org/1582683003/diff/1/runtime/vm/profiler_test.cc...
runtime/vm/profiler_test.cc:1451: FLAG_background_compilation = false;
On 2016/01/12 22:27:50, Cutch wrote:
> Might want to introduce a Scope object like DisableNativeProfileScope above
for
> swapping this flag.

Done, here and Profiler_FunctionInline

[rmacnak, 2016-01-13 00:45:06]

Description was changed from

==========
Fall back to inlining intervals to generate stack traces in --noopt. Inlined
frames will lack line and column positions, but they will at least be expanded.

Fix stack traces when visible functions are inlined into an invisible function.

Fix off-by-one expanding inlined functions in the profiler.

BUG=http://dartbug.com/24783
==========

to

==========
Fall back to inlining intervals to generate stack traces in --noopt. Inlined
frames will lack line and column positions, but they will at least be expanded.

Fix stack traces when visible functions are inlined into an invisible function.

Fix off-by-one expanding inlined functions in the profiler.

BUG=http://dartbug.com/24783
R=johnmccutchan@google.com

Committed:
https://github.com/dart-lang/sdk/commit/80702cb2722f70906d4f2c5a32b0e2a14ad8aa20
==========

[rmacnak, 2016-01-13 00:45:07]

Committed patchset #2 (id:20001) manually as
80702cb2722f70906d4f2c5a32b0e2a14ad8aa20 (presubmit successful).