dart2js cps: Preserve parameter hints during eta and beta reductions.

dart2js cps: Preserve parameter hints during eta and beta reductions.

BUG=
R=kmillikin@google.com

Committed: https://github.com/dart-lang/sdk/commit/e6cc028c6fc86c3f30b954d49729db1ed1968fd0

[asgerf, 2016-01-12 19:19:47]

asgerf@google.com changed reviewers:
+ kmillikin@google.com, sra@google.com

[Kevin Millikin (Google), 2016-01-12 20:10:05]

LGTM.

https://codereview.chromium.org/1582643002/diff/1/pkg/compiler/lib/src/cps_ir...
File pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart (right):

https://codereview.chromium.org/1582643002/diff/1/pkg/compiler/lib/src/cps_ir...
pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart:144:
invoke.arguments[i].definition.useElementAsHint(cont.parameters[i].hint);
This would be clearer if the name useElementAsHint indicated that it was
conditional.  I can't think of an obviously great name.

[asgerf, 2016-01-12 20:21:32]

https://codereview.chromium.org/1582643002/diff/1/pkg/compiler/lib/src/cps_ir...
File pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart (right):

https://codereview.chromium.org/1582643002/diff/1/pkg/compiler/lib/src/cps_ir...
pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart:144:
invoke.arguments[i].definition.useElementAsHint(cont.parameters[i].hint);
On 2016/01/12 20:10:05, Kevin Millikin (Google) wrote:
> This would be clearer if the name useElementAsHint indicated that it was
> conditional.  I can't think of an obviously great name.

Now that we have the ??= operator maybe we should just inline it.

[asgerf, 2016-01-12 23:12:52]

Description was changed from

==========
dart2js cps: Preserve parameter hints during eta and beta reductions.

BUG=
==========

to

==========
dart2js cps: Preserve parameter hints during eta and beta reductions.

BUG=
R=kmillikin@google.com

Committed:
https://github.com/dart-lang/sdk/commit/e6cc028c6fc86c3f30b954d49729db1ed1968fd0
==========

[asgerf, 2016-01-12 23:12:54]

Committed patchset #1 (id:1) manually as
e6cc028c6fc86c3f30b954d49729db1ed1968fd0 (presubmit successful).