Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1582613010: Use getResolvedCompilationUnit2() instead of resolveCompilationUnit2() in QuickAssist and QuickFix … (Closed)

Created:
4 years, 11 months ago by scheglov
Modified:
4 years, 11 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use getResolvedCompilationUnit2() instead of resolveCompilationUnit2() in QuickAssist and QuickFix contributors. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/1c5e2fd0fbde183c321fc88114de915662ffcecd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M pkg/analysis_server/lib/plugin/edit/assist/assist_dart.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analysis_server/lib/plugin/edit/fix/fix_dart.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
4 years, 11 months ago (2016-01-15 19:52:02 UTC) #1
Brian Wilkerson
LGTM
4 years, 11 months ago (2016-01-15 20:13:21 UTC) #2
scheglov
4 years, 11 months ago (2016-01-15 20:15:50 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
1c5e2fd0fbde183c321fc88114de915662ffcecd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698