Ozone support for multiprocess graphics.

Ozone support for multiprocess graphics.

VgemPixmap allows scanout of gem handle imported by file descriptor.

Change-Id: I233b3992f2289754c904da94f98d4707cd227d0d

BUG=
R=cstout@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/c0962d0d0c9ab1151ce40d6233231634fbcddaba

[Forrest Reiling, 2016-01-19 21:25:13]

freiling@chromium.org changed reviewers:
+ cstout@chromium.org, jamesr@chromium.org

[cdotstout, 2016-02-01 19:06:05]

https://codereview.chromium.org/1582613004/diff/1/ui/ozone/platform/drm/gpu/v...
File ui/ozone/platform/drm/gpu/vgem_pixmap.h (right):

https://codereview.chromium.org/1582613004/diff/1/ui/ozone/platform/drm/gpu/v...
ui/ozone/platform/drm/gpu/vgem_pixmap.h:18: // VgemPixmap is a reference to a
dmabuf file descriptor.
Not in love with the name I used here.  How about DrmDmabufPixmap instead?

// DrmDmabufPixmap is a reference to a drm (PRIME) dmabuf file descriptor.

We should also probably make scanout optional.  But for now we could just
document that it assumes scanout.

[Forrest Reiling, 2016-02-10 19:13:35]

https://codereview.chromium.org/1582613004/diff/1/ui/ozone/platform/drm/gpu/v...
File ui/ozone/platform/drm/gpu/vgem_pixmap.h (right):

https://codereview.chromium.org/1582613004/diff/1/ui/ozone/platform/drm/gpu/v...
ui/ozone/platform/drm/gpu/vgem_pixmap.h:18: // VgemPixmap is a reference to a
dmabuf file descriptor.
On 2016/02/01 19:06:05, cdotstout wrote:
> Not in love with the name I used here.  How about DrmDmabufPixmap instead?
> 
> // DrmDmabufPixmap is a reference to a drm (PRIME) dmabuf file descriptor.
> 
> We should also probably make scanout optional.  But for now we could just
> document that it assumes scanout.

Done.

[cdotstout, 2016-02-12 18:28:25]

On 2016/02/10 19:13:35, Forrest Reiling wrote:
>
https://codereview.chromium.org/1582613004/diff/1/ui/ozone/platform/drm/gpu/v...
> File ui/ozone/platform/drm/gpu/vgem_pixmap.h (right):
> 
>
https://codereview.chromium.org/1582613004/diff/1/ui/ozone/platform/drm/gpu/v...
> ui/ozone/platform/drm/gpu/vgem_pixmap.h:18: // VgemPixmap is a reference to a
> dmabuf file descriptor.
> On 2016/02/01 19:06:05, cdotstout wrote:
> > Not in love with the name I used here.  How about DrmDmabufPixmap instead?
> > 
> > // DrmDmabufPixmap is a reference to a drm (PRIME) dmabuf file descriptor.
> > 
> > We should also probably make scanout optional.  But for now we could just
> > document that it assumes scanout.
> 
> Done.

Can you also change the file names and header guard names? :)

[Forrest Reiling, 2016-02-12 19:43:43]

On 2016/02/12 18:28:25, cdotstout wrote:
> On 2016/02/10 19:13:35, Forrest Reiling wrote:
> >
>
https://codereview.chromium.org/1582613004/diff/1/ui/ozone/platform/drm/gpu/v...
> > File ui/ozone/platform/drm/gpu/vgem_pixmap.h (right):
> > 
> >
>
https://codereview.chromium.org/1582613004/diff/1/ui/ozone/platform/drm/gpu/v...
> > ui/ozone/platform/drm/gpu/vgem_pixmap.h:18: // VgemPixmap is a reference to
a
> > dmabuf file descriptor.
> > On 2016/02/01 19:06:05, cdotstout wrote:
> > > Not in love with the name I used here.  How about DrmDmabufPixmap instead?
> > > 
> > > // DrmDmabufPixmap is a reference to a drm (PRIME) dmabuf file descriptor.
> > > 
> > > We should also probably make scanout optional.  But for now we could just
> > > document that it assumes scanout.
> > 
> > Done.
> 
> Can you also change the file names and header guard names? :)

#ReluctantGroan But yeah I'll pick it up on my next pass through all these
changes

[jamesr, 2016-02-12 21:39:31]

On 2016/02/12 at 19:43:43, freiling wrote:
> On 2016/02/12 18:28:25, cdotstout wrote:
> > On 2016/02/10 19:13:35, Forrest Reiling wrote:
> > >
> >
https://codereview.chromium.org/1582613004/diff/1/ui/ozone/platform/drm/gpu/v...
> > > File ui/ozone/platform/drm/gpu/vgem_pixmap.h (right):
> > > 
> > >
> >
https://codereview.chromium.org/1582613004/diff/1/ui/ozone/platform/drm/gpu/v...
> > > ui/ozone/platform/drm/gpu/vgem_pixmap.h:18: // VgemPixmap is a reference
to a
> > > dmabuf file descriptor.
> > > On 2016/02/01 19:06:05, cdotstout wrote:
> > > > Not in love with the name I used here.  How about DrmDmabufPixmap
instead?
> > > > 
> > > > // DrmDmabufPixmap is a reference to a drm (PRIME) dmabuf file
descriptor.
> > > > 
> > > > We should also probably make scanout optional.  But for now we could
just
> > > > document that it assumes scanout.
> > > 
> > > Done.
> > 
> > Can you also change the file names and header guard names? :)
> 
> #ReluctantGroan But yeah I'll pick it up on my next pass through all these
changes

git mv old new
./tools/git/mass-rename.sh

that script will update header guards, update includes (and re-sort include
blocks), and make an attempt at updating build files.  it won't get everything
perfect but it will automate 99% of the grunt work

[Forrest Reiling, 2016-02-16 21:18:35]

On 2016/02/12 21:39:31, jamesr wrote:
> On 2016/02/12 at 19:43:43, freiling wrote:
> > On 2016/02/12 18:28:25, cdotstout wrote:
> > > On 2016/02/10 19:13:35, Forrest Reiling wrote:
> > > >
> > >
>
https://codereview.chromium.org/1582613004/diff/1/ui/ozone/platform/drm/gpu/v...
> > > > File ui/ozone/platform/drm/gpu/vgem_pixmap.h (right):
> > > > 
> > > >
> > >
>
https://codereview.chromium.org/1582613004/diff/1/ui/ozone/platform/drm/gpu/v...
> > > > ui/ozone/platform/drm/gpu/vgem_pixmap.h:18: // VgemPixmap is a reference
> to a
> > > > dmabuf file descriptor.
> > > > On 2016/02/01 19:06:05, cdotstout wrote:
> > > > > Not in love with the name I used here.  How about DrmDmabufPixmap
> instead?
> > > > > 
> > > > > // DrmDmabufPixmap is a reference to a drm (PRIME) dmabuf file
> descriptor.
> > > > > 
> > > > > We should also probably make scanout optional.  But for now we could
> just
> > > > > document that it assumes scanout.
> > > > 
> > > > Done.
> > > 
> > > Can you also change the file names and header guard names? :)
> > 
> > #ReluctantGroan But yeah I'll pick it up on my next pass through all these
> changes
> 
> git mv old new
> ./tools/git/mass-rename.sh
> 
> that script will update header guards, update includes (and re-sort include
> blocks), and make an attempt at updating build files.  it won't get everything
> perfect but it will automate 99% of the grunt work

Wow that was actually surprisingly painless

[Forrest Reiling, 2016-02-26 00:11:13]

All outstanding changes are in. PTAL

[cdotstout, 2016-03-03 00:29:36]

lgtm

[Forrest Reiling, 2016-03-03 00:57:43]

Description was changed from

==========
Ozone support for multiprocess graphics.

VgemPixmap allows scanout of gem handle imported by file descriptor.

Change-Id: I233b3992f2289754c904da94f98d4707cd227d0d

BUG=
==========

to

==========
Ozone support for multiprocess graphics.

VgemPixmap allows scanout of gem handle imported by file descriptor.

Change-Id: I233b3992f2289754c904da94f98d4707cd227d0d

BUG=
R=cstout@chromium.org

Committed:
https://chromium.googlesource.com/external/mojo/+/c0962d0d0c9ab1151ce40d62332...
==========

[Forrest Reiling, 2016-03-03 00:57:44]

Committed patchset #7 (id:120001) manually as
c0962d0d0c9ab1151ce40d6233231634fbcddaba (presubmit successful).