Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Issue 1582613002: [win] Create a SyzyAsan/Chrome/Kasko/Crashpad integration test. (Closed)

Created:
4 years, 11 months ago by chrisha
Modified:
4 years, 11 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[win] Create a SyzyAsan/Chrome/Kasko/Crashpad integration test. BUG= Committed: https://crrev.com/ee7344263519dd120a3b8d0280f56005e2b429ae Cr-Commit-Position: refs/heads/master@{#369416}

Patch Set 1 #

Patch Set 2 : Slight refactor to use pre-instrumented binaries. #

Total comments: 2

Patch Set 3 : Updated comments. #

Patch Set 4 : Update file permissions. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+881 lines, -493 lines) Patch
M chrome/test/kasko/kasko_integration_test.py View 1 2 4 chunks +17 lines, -493 lines 0 comments Download
A chrome/test/kasko/py/kasko/__init__.py View 1 2 3 1 chunk +11 lines, -0 lines 0 comments Download
A chrome/test/kasko/py/kasko/config.py View 1 2 3 1 chunk +86 lines, -0 lines 0 comments Download
A chrome/test/kasko/py/kasko/crash_server.py View 1 2 3 1 chunk +148 lines, -0 lines 0 comments Download
A chrome/test/kasko/py/kasko/exceptions.py View 1 2 3 1 chunk +10 lines, -0 lines 0 comments Download
A chrome/test/kasko/py/kasko/process.py View 1 2 3 1 chunk +222 lines, -0 lines 0 comments Download
A chrome/test/kasko/py/kasko/report.py View 1 2 3 1 chunk +35 lines, -0 lines 0 comments Download
A chrome/test/kasko/py/kasko/util.py View 1 2 3 1 chunk +77 lines, -0 lines 0 comments Download
A chrome/test/kasko/syzyasan_integration_test.py View 1 2 3 1 chunk +275 lines, -0 lines 0 comments Download

Messages

Total messages: 20 (9 generated)
chrisha
Everything in py/kasko is simply a cut and paste of things that were in kasko_integration_test.py, ...
4 years, 11 months ago (2016-01-12 19:40:57 UTC) #2
chrisha
Ping?
4 years, 11 months ago (2016-01-13 15:32:27 UTC) #3
Sébastien Marchand
lgtm https://codereview.chromium.org/1582613002/diff/20001/chrome/test/kasko/syzyasan_integration_test.py File chrome/test/kasko/syzyasan_integration_test.py (right): https://codereview.chromium.org/1582613002/diff/20001/chrome/test/kasko/syzyasan_integration_test.py#newcode19 chrome/test/kasko/syzyasan_integration_test.py:19: branding=Chrome syzyasan=1 win_z7=0 chromium_win_pch=0 buildtype=Official too ? not ...
4 years, 11 months ago (2016-01-13 15:47:19 UTC) #4
chrisha
https://codereview.chromium.org/1582613002/diff/20001/chrome/test/kasko/syzyasan_integration_test.py File chrome/test/kasko/syzyasan_integration_test.py (right): https://codereview.chromium.org/1582613002/diff/20001/chrome/test/kasko/syzyasan_integration_test.py#newcode19 chrome/test/kasko/syzyasan_integration_test.py:19: branding=Chrome syzyasan=1 win_z7=0 chromium_win_pch=0 On 2016/01/13 15:47:19, Sébastien Marchand ...
4 years, 11 months ago (2016-01-13 18:55:14 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1582613002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1582613002/40001
4 years, 11 months ago (2016-01-13 18:56:29 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/135093)
4 years, 11 months ago (2016-01-13 19:08:44 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1582613002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1582613002/60001
4 years, 11 months ago (2016-01-13 20:41:25 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) linux_chromium_chromeos_compile_dbg_ng on ...
4 years, 11 months ago (2016-01-13 23:46:44 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1582613002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1582613002/60001
4 years, 11 months ago (2016-01-14 15:24:58 UTC) #17
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 11 months ago (2016-01-14 15:31:00 UTC) #18
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 15:32:23 UTC) #20
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/ee7344263519dd120a3b8d0280f56005e2b429ae
Cr-Commit-Position: refs/heads/master@{#369416}

Powered by Google App Engine
This is Rietveld 408576698