Fix BufferedSocketWriter to buffer everything before it starts writing.

remoting/base/buffered_socket_writer.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef REMOTING_BASE_BUFFERED_SOCKET_WRITER_H_
 #define REMOTING_BASE_BUFFERED_SOCKET_WRITER_H_
 
 #include <list>
 
 #include "base/callback.h"
@@ skipping 18 matching lines @@
       WriteCallback;
   typedef base::Callback<void(int)> WriteFailedCallback;
 
   static scoped_ptr<BufferedSocketWriter> CreateForSocket(
       net::Socket* socket,
       const WriteFailedCallback& write_failed_callback);
 
   BufferedSocketWriter();
   virtual ~BufferedSocketWriter();
 
-  // Initializes the writer. |write_callback| is called to write data to the
+  // Starts the writer. |write_callback| is called to write data to the
   // socket. |write_failed_callback| is called when write operation fails.
   // Writing stops after the first failed write.
-  void Init(const WriteCallback& write_callback,
-            const WriteFailedCallback& write_failed_callback);
+  void Start(const WriteCallback& write_callback,
+             const WriteFailedCallback& write_failed_callback);
 
-  // Puts a new data chunk in the buffer.
+  // Puts a new data chunk in the buffer. If called before Start() then all data
+  // is buffered until Start().
   void Write(const scoped_refptr<net::IOBufferWithSize>& buffer,
              const base::Closure& done_task);
 
   // Returns true when there is data waiting to be written.
   bool has_data_pending() { return !queue_.empty(); }
 
  private:
   struct PendingPacket;
   typedef std::list<PendingPacket*> DataQueue;
 
-  // Returns true if the writer is closed due to an error.
-  bool is_closed();
-
   void DoWrite();
   void HandleWriteResult(int result);
   void OnWritten(int result);
 
   base::ThreadChecker thread_checker_;
 
   WriteCallback write_callback_;
   WriteFailedCallback write_failed_callback_;
 
+  bool closed_ = false;
+
   DataQueue queue_;
 
   bool write_pending_ = false;
 
   base::WeakPtrFactory<BufferedSocketWriter> weak_factory_;
 };
 
 }  // namespace remoting
 
 #endif  // REMOTING_BASE_BUFFERED_SOCKET_WRITER_H_