Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 1582573002: InnerPointerToCodeCache::GetCacheEntry() made deterministic in predictable mode. (Closed)

Created:
4 years, 11 months ago by Igor Sheludko
Modified:
4 years, 11 months ago
Reviewers:
Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

InnerPointerToCodeCache::GetCacheEntry() made deterministic in predictable mode. The hash calculation was dependent on upper part of |inner_pointer| and caused non-deterministic cache miss events which in turn caused non-deterministic progress of pages sweeping (see GcSafeFindCodeForInnerPointer()). Committed: https://crrev.com/07c52763bb207b3dee5bb9f7aea201a1c51634d2 Cr-Commit-Position: refs/heads/master@{#33246}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M src/frames.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M src/objects.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/objects-inl.h View 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
Igor Sheludko
PTAL
4 years, 11 months ago (2016-01-12 14:58:47 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1582573002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1582573002/20001
4 years, 11 months ago (2016-01-12 15:51:02 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 11 months ago (2016-01-12 16:26:45 UTC) #7
Jakob Kummerow
lgtm
4 years, 11 months ago (2016-01-12 17:08:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1582573002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1582573002/20001
4 years, 11 months ago (2016-01-12 17:09:17 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 11 months ago (2016-01-12 18:09:56 UTC) #11
commit-bot: I haz the power
4 years, 11 months ago (2016-01-12 18:10:24 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/07c52763bb207b3dee5bb9f7aea201a1c51634d2
Cr-Commit-Position: refs/heads/master@{#33246}

Powered by Google App Engine
This is Rietveld 408576698