chrome/browser/ui/browser.cc - Issue 158253002: Tabs being screen-captured will fullscreen within their tab contents area.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/browser.cc

Issue 158253002: Tabs being screen-captured will fullscreen within their tab contents area. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Add DCHECK to make sure tab capture isn't started after tab fullscreen. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/browser.cc

diff --git a/chrome/browser/ui/browser.cc b/chrome/browser/ui/browser.cc

index 87acf52c3f42ef8b404ee151571318bd5cbfd81b..38858828e5aafd426d309236d30dd0eb946d22eb 100644

--- a/chrome/browser/ui/browser.cc

+++ b/chrome/browser/ui/browser.cc

@@ -981,6 +981,8 @@ void Browser::ActiveTabChanged(WebContents* old_contents,

// is updated.

window_->OnActiveTabChanged(old_contents, new_contents, index, reason);

+ fullscreen_controller_->OnTabDetachedFromView(old_contents);

// Discarded tabs always get reloaded.

if (tab_strip_model_->IsTabDiscarded(index)) {

LOG(WARNING) << "Reloading discarded tab at " << index;

« no previous file with comments | « no previous file | chrome/browser/ui/fullscreen/fullscreen_controller.h » ('j') | no next file with comments »