Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Unified Diff: chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeInstrumentationTestRunner.java

Issue 1582513003: Add a testing restriction for whether Google Play Services is up-to-date. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeInstrumentationTestRunner.java
diff --git a/chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeInstrumentationTestRunner.java b/chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeInstrumentationTestRunner.java
index 25fb441181fb564e6283a3789dce5c4d8b7c0e1f..de0c1ba6876ccf2f89d5c84619bc0560f4d31b7b 100644
--- a/chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeInstrumentationTestRunner.java
+++ b/chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeInstrumentationTestRunner.java
@@ -10,13 +10,16 @@ import android.os.Environment;
import android.text.TextUtils;
import android.util.Log;
+import com.google.android.gms.common.ConnectionResult;
+import com.google.android.gms.common.GoogleApiAvailability;
+
import junit.framework.TestCase;
import org.chromium.base.test.BaseInstrumentationTestRunner;
import org.chromium.base.test.BaseTestResult;
-import org.chromium.base.test.util.Restriction;
import org.chromium.base.test.util.SkipCheck;
import org.chromium.chrome.browser.util.FeatureUtilities;
+import org.chromium.chrome.test.util.ChromeRestriction;
import org.chromium.chrome.test.util.DisableInTabbedMode;
import org.chromium.net.test.BaseHttpTestServer;
import org.chromium.policy.test.annotations.Policies;
@@ -220,16 +223,23 @@ public class ChromeInstrumentationTestRunner extends BaseInstrumentationTestRunn
}
private class ChromeRestrictionSkipCheck extends RestrictionSkipCheck {
+
@Override
protected boolean restrictionApplies(String restriction) {
- if (TextUtils.equals(restriction, Restriction.RESTRICTION_TYPE_PHONE)
+ if (TextUtils.equals(restriction, ChromeRestriction.RESTRICTION_TYPE_PHONE)
&& DeviceFormFactor.isTablet(getTargetContext())) {
return true;
}
- if (TextUtils.equals(restriction, Restriction.RESTRICTION_TYPE_TABLET)
+ if (TextUtils.equals(restriction, ChromeRestriction.RESTRICTION_TYPE_TABLET)
&& !DeviceFormFactor.isTablet(getTargetContext())) {
return true;
}
+ if (TextUtils.equals(restriction,
+ ChromeRestriction.RESTRICTION_TYPE_GOOGLE_PLAY_SERVICES)
+ && (ConnectionResult.SUCCESS != GoogleApiAvailability.getInstance()
+ .isGooglePlayServicesAvailable(getTargetContext()))) {
+ return true;
+ }
return false;
}
}
« no previous file with comments | « chrome/test/android/BUILD.gn ('k') | chrome/test/android/javatests/src/org/chromium/chrome/test/util/ChromeRestriction.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698