content/public/android/javatests/src/org/chromium/content/browser/WebContentsObserverAndroidTest.java - Issue 1582513003: Add a testing restriction for whether Google Play Services is up-to-date.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/WebContentsObserverAndroidTest.java

Issue 1582513003: Add a testing restriction for whether Google Play Services is up-to-date. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/test/android/javatests/src/org/chromium/chrome/test/util/ChromeRestriction.java ('K') | « chrome/test/android/javatests/src/org/chromium/chrome/test/util/ChromeRestriction.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/javatests/src/org/chromium/content/browser/WebContentsObserverAndroidTest.java

diff --git a/content/public/android/javatests/src/org/chromium/content/browser/WebContentsObserverAndroidTest.java b/content/public/android/javatests/src/org/chromium/content/browser/WebContentsObserverAndroidTest.java

index 0ab51f13745f2ebbcbd6d97f8a2f91551cb5fa1a..800e3e0ea8c6a979c9eb3c5428ba6103273aea65 100644

--- a/content/public/android/javatests/src/org/chromium/content/browser/WebContentsObserverAndroidTest.java

+++ b/content/public/android/javatests/src/org/chromium/content/browser/WebContentsObserverAndroidTest.java

@@ -4,8 +4,10 @@

package org.chromium.content.browser;

+import android.test.suitebuilder.annotation.SmallTest;

import org.chromium.base.ThreadUtils;

-import org.chromium.base.test.util.DisabledTest;

+import org.chromium.base.test.util.Feature;

import org.chromium.base.test.util.UrlUtils;

import org.chromium.content.browser.test.util.CallbackHelper;

import org.chromium.content_public.browser.LoadUrlParams;

@@ -24,7 +26,8 @@ public class WebContentsObserverAndroidTest extends ContentShellTestBase {

"<html><head></head><body>didFirstVisuallyNonEmptyPaint test</body></html>");

private static class TestWebContentsObserver extends WebContentsObserver {

- private CallbackHelper mDidFirstVisuallyNonEmptyPaintCallbackHelper = new CallbackHelper();

+ private final CallbackHelper mDidFirstVisuallyNonEmptyPaintCallbackHelper =

+ new CallbackHelper();

public TestWebContentsObserver(WebContents webContents) {

super(webContents);

@@ -48,12 +51,8 @@ public class WebContentsObserverAndroidTest extends ContentShellTestBase {

waitForActiveShellToBeDoneLoading();

}

- /*

@SmallTest

@Feature({"Navigation"})

- http://crbug.com/411931

- */

- @DisabledTest

public void testDidFirstVisuallyNonEmptyPaint() throws Throwable {

TestWebContentsObserver observer = ThreadUtils.runOnUiThreadBlocking(

new Callable<TestWebContentsObserver>() {