Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3315)

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/widget/OverviewListLayoutTest.java

Issue 1582513003: Add a testing restriction for whether Google Play Services is up-to-date. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/javatests/src/org/chromium/chrome/browser/widget/OverviewListLayoutTest.java
diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/widget/OverviewListLayoutTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/widget/OverviewListLayoutTest.java
index dc51eaeb184c3a11aa19a84b0d4361c8d27731a2..75981c043197a0742b7921eeb0df35f738b89d26 100644
--- a/chrome/android/javatests/src/org/chromium/chrome/browser/widget/OverviewListLayoutTest.java
+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/widget/OverviewListLayoutTest.java
@@ -4,9 +4,6 @@
package org.chromium.chrome.browser.widget;
-import static org.chromium.base.test.util.Restriction.RESTRICTION_TYPE_PHONE;
-import static org.chromium.base.test.util.Restriction.RESTRICTION_TYPE_TABLET;
-
import android.os.SystemClock;
import android.test.suitebuilder.annotation.MediumTest;
import android.view.View;
@@ -17,7 +14,6 @@ import android.widget.TextView;
import org.chromium.base.CommandLine;
import org.chromium.base.ThreadUtils;
import org.chromium.base.test.util.Feature;
-import org.chromium.base.test.util.Restriction;
import org.chromium.chrome.R;
import org.chromium.chrome.browser.ChromeSwitches;
import org.chromium.chrome.browser.compositor.overlays.strip.StripLayoutTab;
@@ -26,6 +22,7 @@ import org.chromium.chrome.browser.tabmodel.EmptyTabModelObserver;
import org.chromium.chrome.browser.tabmodel.TabModel;
import org.chromium.chrome.browser.widget.accessibility.AccessibilityTabModelListItem;
import org.chromium.chrome.test.ChromeTabbedActivityTestBase;
+import org.chromium.chrome.test.util.ChromeRestriction;
import org.chromium.chrome.test.util.ChromeTabUtils;
import org.chromium.chrome.test.util.MenuUtils;
import org.chromium.chrome.test.util.TabStripUtils;
@@ -149,7 +146,7 @@ public class OverviewListLayoutTest extends ChromeTabbedActivityTestBase {
});
}
- @Restriction(RESTRICTION_TYPE_PHONE)
+ @ChromeRestriction(ChromeRestriction.RESTRICTION_TYPE_PHONE)
@MediumTest
@Feature({"Accessibility"})
public void testCanEnterSwitcher() {
@@ -160,7 +157,7 @@ public class OverviewListLayoutTest extends ChromeTabbedActivityTestBase {
assertNotNull("Accessibility container was not visible", getContainer().getParent());
}
- @Restriction(RESTRICTION_TYPE_PHONE)
+ @ChromeRestriction(ChromeRestriction.RESTRICTION_TYPE_PHONE)
@MediumTest
@Feature({"Accessibility"})
public void testCanLeaveSwitcher() {
@@ -175,7 +172,7 @@ public class OverviewListLayoutTest extends ChromeTabbedActivityTestBase {
assertNull("Accessibility container was not visible", getContainer().getParent());
}
- @Restriction(RESTRICTION_TYPE_PHONE)
+ @ChromeRestriction(ChromeRestriction.RESTRICTION_TYPE_PHONE)
@MediumTest
@Feature({"Accessibility"})
public void testCanCloseWithCloseButton() throws InterruptedException, TimeoutException {
@@ -205,7 +202,7 @@ public class OverviewListLayoutTest extends ChromeTabbedActivityTestBase {
});
}
- @Restriction(RESTRICTION_TYPE_PHONE)
+ @ChromeRestriction(ChromeRestriction.RESTRICTION_TYPE_PHONE)
@MediumTest
@Feature({"Accessibility"})
public void testCanSwipeClosed() throws InterruptedException, TimeoutException {
@@ -240,7 +237,7 @@ public class OverviewListLayoutTest extends ChromeTabbedActivityTestBase {
});
}
- @Restriction(RESTRICTION_TYPE_PHONE)
+ @ChromeRestriction(ChromeRestriction.RESTRICTION_TYPE_PHONE)
@MediumTest
@Feature({"Accessibility"})
public void testResetSwipe() throws InterruptedException {
@@ -261,7 +258,7 @@ public class OverviewListLayoutTest extends ChromeTabbedActivityTestBase {
});
}
- @Restriction(RESTRICTION_TYPE_PHONE)
+ @ChromeRestriction(ChromeRestriction.RESTRICTION_TYPE_PHONE)
@MediumTest
@Feature({"Accessibility"})
public void testCloseAndUndo() throws InterruptedException, TimeoutException {
@@ -296,7 +293,7 @@ public class OverviewListLayoutTest extends ChromeTabbedActivityTestBase {
});
}
- @Restriction(RESTRICTION_TYPE_PHONE)
+ @ChromeRestriction(ChromeRestriction.RESTRICTION_TYPE_PHONE)
@MediumTest
@Feature({"Accessibility"})
public void testCloseAll() throws InterruptedException {
@@ -310,7 +307,7 @@ public class OverviewListLayoutTest extends ChromeTabbedActivityTestBase {
assertFalse(getActivity().findViewById(R.id.tab_switcher_button).isEnabled());
}
- @Restriction(RESTRICTION_TYPE_PHONE)
+ @ChromeRestriction(ChromeRestriction.RESTRICTION_TYPE_PHONE)
@MediumTest
@Feature({"Accessibility"})
public void testCloseAllIncognito() throws InterruptedException {
@@ -335,7 +332,7 @@ public class OverviewListLayoutTest extends ChromeTabbedActivityTestBase {
assertFalse(getActivity().findViewById(R.id.tab_switcher_button).isEnabled());
}
- @Restriction(RESTRICTION_TYPE_PHONE)
+ @ChromeRestriction(ChromeRestriction.RESTRICTION_TYPE_PHONE)
@MediumTest
@Feature({"Accessibility"})
public void testModelSwitcherVisibility() throws InterruptedException {
@@ -355,7 +352,7 @@ public class OverviewListLayoutTest extends ChromeTabbedActivityTestBase {
switcherButtons.getVisibility());
}
- @Restriction(RESTRICTION_TYPE_PHONE)
+ @ChromeRestriction(ChromeRestriction.RESTRICTION_TYPE_PHONE)
@MediumTest
@Feature({"Accessibility"})
public void testModelSwitcherFunctionality() throws InterruptedException {
@@ -411,7 +408,7 @@ public class OverviewListLayoutTest extends ChromeTabbedActivityTestBase {
assertEquals("Page 2", getTabTitleOfListItem(0));
}
- @Restriction(RESTRICTION_TYPE_TABLET)
+ @ChromeRestriction(ChromeRestriction.RESTRICTION_TYPE_TABLET)
@MediumTest
@Feature({"Accessibility"})
public void testCloseTabThroughTabStrip() throws InterruptedException, TimeoutException {

Powered by Google App Engine
This is Rietveld 408576698