Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Unified Diff: base/test/android/javatests/src/org/chromium/base/test/util/Restriction.java

Issue 1582513003: Add a testing restriction for whether Google Play Services is up-to-date. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/test/android/javatests/src/org/chromium/base/test/util/Restriction.java
diff --git a/base/test/android/javatests/src/org/chromium/base/test/util/Restriction.java b/base/test/android/javatests/src/org/chromium/base/test/util/Restriction.java
index 4b561a6f6fd966d39bff9b87ab269242c4e9947b..a54d0e530aaa8c9d589becd13bcf6ebe8fcee32c 100644
--- a/base/test/android/javatests/src/org/chromium/base/test/util/Restriction.java
+++ b/base/test/android/javatests/src/org/chromium/base/test/util/Restriction.java
@@ -12,18 +12,12 @@ import java.lang.annotation.Target;
/**
* An annotation for listing restrictions for a test method. For example, if a test method is only
* applicable on a phone with small memory:
- * @Restriction({RESTRICTION_TYPE_PHONE, RESTRICTION_TYPE_SMALL_MEMORY})
+ * @Restriction({RESTRICTION_TYPE_LOW_END_DEVICE, RESTRICTION_TYPE_SMALL_MEMORY})
* Test classes are free to define restrictions and enforce them using reflection at runtime.
*/
@Target(ElementType.METHOD)
@Retention(RetentionPolicy.RUNTIME)
public @interface Restriction {
- /** Specifies the test is only valid on phone form factors. */
- public static final String RESTRICTION_TYPE_PHONE = "Phone";
-
- /** Specifies the test is only valid on tablet form factors. */
- public static final String RESTRICTION_TYPE_TABLET = "Tablet";
-
/** Specifies the test is only valid on low end devices that have less memory. */
public static final String RESTRICTION_TYPE_LOW_END_DEVICE = "Low_End_Device";

Powered by Google App Engine
This is Rietveld 408576698