Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2652)

Unified Diff: base/test/android/javatests/src/org/chromium/base/test/util/Restriction.java

Issue 1582513003: Add a testing restriction for whether Google Play Services is up-to-date. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/test/android/javatests/src/org/chromium/base/test/util/Restriction.java
diff --git a/base/test/android/javatests/src/org/chromium/base/test/util/Restriction.java b/base/test/android/javatests/src/org/chromium/base/test/util/Restriction.java
index 4b561a6f6fd966d39bff9b87ab269242c4e9947b..700f04e02aa457bc5d6f3671683120981f6c520c 100644
--- a/base/test/android/javatests/src/org/chromium/base/test/util/Restriction.java
+++ b/base/test/android/javatests/src/org/chromium/base/test/util/Restriction.java
@@ -18,10 +18,10 @@ import java.lang.annotation.Target;
@Target(ElementType.METHOD)
@Retention(RetentionPolicy.RUNTIME)
public @interface Restriction {
- /** Specifies the test is only valid on phone form factors. */
+ /** Specifies the test is only valid on phone form factors. Only valid in chrome/ layer */
jbudorick 2016/01/13 14:43:50 1) Why are these two only valid in the chrome/ lay
Yaron 2016/01/13 15:54:30 They're only processed by ChromeRestrictionSkipChe
jbudorick 2016/01/13 16:54:50 sgtm
public static final String RESTRICTION_TYPE_PHONE = "Phone";
- /** Specifies the test is only valid on tablet form factors. */
+ /** Specifies the test is only valid on tablet form factors. Only valid in chrome/ layer */
public static final String RESTRICTION_TYPE_TABLET = "Tablet";
/** Specifies the test is only valid on low end devices that have less memory. */
@@ -33,6 +33,11 @@ public @interface Restriction {
/** Specifies the test is only valid on a device that can reach the internet. */
public static final String RESTRICTION_TYPE_INTERNET = "Internet";
+ /** Specifies the test is only valid on a device that has up to date play services.
+ * Only valid in chrome/ layer.
+ */
+ public static final String RESTRICTION_TYPE_GOOGLE_PLAY_SERVICES = "Google_Play_Services";
+
/**
* @return A list of restrictions.
*/

Powered by Google App Engine
This is Rietveld 408576698