Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issue 1582443003: Switch to using HashChangeEvent constructor instead of initHashChangeEvent (Closed)

Created:
4 years, 11 months ago by Alan Knight
Modified:
4 years, 11 months ago
Reviewers:
terry
CC:
reviews_dartlang.org, ricow1
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Switch to using HashChangeEvent constructor instead of initHashChangeEvent BUG= Committed: https://github.com/dart-lang/sdk/commit/914bf02cdea7dfed947b87931bbe266de81fad9c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -5 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 chunk +10 lines, -3 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 1 chunk +4 lines, -0 lines 0 comments Download
M tests/html/html.status View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/dom/templates/html/impl/impl_HashChangeEvent.darttemplate View 1 chunk +15 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
Alan Knight
TBR - will put this on the bots and verify it's working in other browsers.
4 years, 11 months ago (2016-01-12 17:42:00 UTC) #2
Alan Knight
4 years, 11 months ago (2016-01-12 17:42:11 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
914bf02cdea7dfed947b87931bbe266de81fad9c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698