Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 1582403004: Linux: Send the product channel to non-browser processes. (Closed)

Created:
4 years, 11 months ago by Lei Zhang
Modified:
4 years, 11 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews, darin-cc_chromium.org, jam, sadrul, kalyank
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Linux: Send the product channel to non-browser processes. BUG=578294 Committed: https://crrev.com/cb7a59a1bcfd574fb48ff9ba62e61c28c11478c6 Cr-Commit-Position: refs/heads/master@{#371431}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Fix Android #

Patch Set 4 : Fix content_browsertests linking #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -5 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 1 1 chunk +6 lines, -2 lines 0 comments Download
M components/crash.gypi View 1 2 3 1 chunk +1 line, -0 lines 1 comment Download
M components/crash/content/app/breakpad_linux.cc View 1 2 3 chunks +32 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
Lei Zhang
While I don't care to do it this way, the alternative of setting the channel ...
4 years, 11 months ago (2016-01-15 23:55:30 UTC) #3
Robert Sesek
I think this is fine. LGTM
4 years, 11 months ago (2016-01-19 15:16:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1582403004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1582403004/1
4 years, 11 months ago (2016-01-22 07:16:21 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/11544)
4 years, 11 months ago (2016-01-22 07:27:28 UTC) #8
Lei Zhang
Made some small changes to fix all failing builds. https://codereview.chromium.org/1582403004/diff/60001/components/crash.gypi File components/crash.gypi (right): https://codereview.chromium.org/1582403004/diff/60001/components/crash.gypi#newcode142 components/crash.gypi:142: ...
4 years, 11 months ago (2016-01-26 00:23:07 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1582403004/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1582403004/60001
4 years, 11 months ago (2016-01-26 01:37:37 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 11 months ago (2016-01-26 02:43:58 UTC) #15
commit-bot: I haz the power
4 years, 11 months ago (2016-01-26 02:45:12 UTC) #17
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/cb7a59a1bcfd574fb48ff9ba62e61c28c11478c6
Cr-Commit-Position: refs/heads/master@{#371431}

Powered by Google App Engine
This is Rietveld 408576698