Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 1582403003: Use ::cue for VTT UA styles. (Closed)

Created:
4 years, 11 months ago by rune
Modified:
4 years, 11 months ago
Reviewers:
fs
CC:
fs, darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, gasubic, mlamouri+watch-blink_chromium.org, philipj_slow, rwlbuis, nessy, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@perf-20160115
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use ::cue for VTT UA styles. Instead of using a custom pseudo element for the track container to apply UA styling to b, i, and u elements, use ::cue selectors. R=fs@opera.com TEST=media/track/track-css-matching-default.html NO_DEPENDENCY_CHECKS=true Committed: https://crrev.com/06763f379c0096701c5caab7573abe2e85a5f0ee Cr-Commit-Position: refs/heads/master@{#369732}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M third_party/WebKit/Source/core/css/mediaControls.css View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/mediaControlsNew.css View 1 chunk +3 lines, -3 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 18 (8 generated)
rune
ptal
4 years, 11 months ago (2016-01-15 11:47:26 UTC) #1
rune
The patch-set dependency is not related.
4 years, 11 months ago (2016-01-15 11:48:56 UTC) #3
fs
lgtm
4 years, 11 months ago (2016-01-15 12:01:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1582403003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1582403003/1
4 years, 11 months ago (2016-01-15 12:06:29 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/8783)
4 years, 11 months ago (2016-01-15 12:19:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1582403003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1582403003/1
4 years, 11 months ago (2016-01-15 12:45:43 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_clang_dbg_recipe/builds/8801)
4 years, 11 months ago (2016-01-15 12:57:40 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1582403003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1582403003/1
4 years, 11 months ago (2016-01-15 13:26:25 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 11 months ago (2016-01-15 13:41:21 UTC) #16
commit-bot: I haz the power
4 years, 11 months ago (2016-01-15 13:42:40 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/06763f379c0096701c5caab7573abe2e85a5f0ee
Cr-Commit-Position: refs/heads/master@{#369732}

Powered by Google App Engine
This is Rietveld 408576698