Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Issue 1582383002: Additional test cases for bug_361 (Closed)

Created:
4 years, 11 months ago by Tom Sepez
Modified:
4 years, 11 months ago
Reviewers:
Lei Zhang, Tom Bergan
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Better tests for NaN. #

Patch Set 3 : Empty string is most obvious test case. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -2 lines) Patch
M testing/resources/javascript/bug_361.in View 1 2 3 chunks +19 lines, -1 line 0 comments Download
M testing/resources/javascript/bug_361_expected.txt View 1 2 3 chunks +19 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Tom Sepez
Pls review.
4 years, 11 months ago (2016-01-14 17:19:27 UTC) #1
Lei Zhang
lgtm
4 years, 11 months ago (2016-01-14 18:24:25 UTC) #2
Tom Sepez
4 years, 11 months ago (2016-01-14 20:12:53 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
1a82d5c28be2ebdb7524a7249e43026546d0ebf0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698