Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(578)

Issue 1582373003: Revert of Create an SkCodecImageGenerator (Closed)

Created:
4 years, 11 months ago by msarett
Modified:
4 years, 11 months ago
Reviewers:
scroggo, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Create an SkCodecImageGenerator (patchset #10 id:260001 of https://codereview.chromium.org/1487683004/ ) Reason for revert: Core doesn't know about Codec. Original issue's description: > Create an SkCodecImageGenerator > > BUG=skia: > > patch from issue 1396323007 at patchset 120001 (http://crrev.com/1396323007#ps120001) > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1487683004 > > Committed: https://skia.googlesource.com/skia/+/e1102ce1d3d0895e840e756e155ec56b5a1a7540 TBR=reed@google.com,scroggo@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/8afddabeaf5084e09d66a99b80ed2c72fa338e59

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -104 lines) Patch
M gyp/core.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M gyp/core.gypi View 1 chunk +0 lines, -1 line 0 comments Download
D src/core/SkCodecImageGenerator.h View 1 chunk +0 lines, -43 lines 0 comments Download
D src/core/SkCodecImageGenerator.cpp View 1 chunk +0 lines, -46 lines 0 comments Download
M tests/CodexTest.cpp View 2 chunks +0 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
msarett
Created Revert of Create an SkCodecImageGenerator
4 years, 11 months ago (2016-01-14 20:20:32 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1582373003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1582373003/1
4 years, 11 months ago (2016-01-14 20:20:37 UTC) #2
commit-bot: I haz the power
4 years, 11 months ago (2016-01-14 20:20:48 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/8afddabeaf5084e09d66a99b80ed2c72fa338e59

Powered by Google App Engine
This is Rietveld 408576698