components/autofill/core/browser/autofill_manager.cc - Issue 1582353006: CountryNames: Separate data creation from usage

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_manager.cc

Issue 1582353006: CountryNames: Separate data creation from usage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@571610_exposeCountryNamesToTesting

Patch Set: Set CountryNames locale also from PersonalDataManager Created 4 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/browser/autofill_field_unittest.cc ('k') | components/autofill/core/browser/autofill_merge_unittest.cc » ('j') | components/autofill/core/browser/country_names.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/browser/autofill_manager.cc

diff --git a/components/autofill/core/browser/autofill_manager.cc b/components/autofill/core/browser/autofill_manager.cc

index 8e2787c4c818f7fbe3b32eb6c4574dc0dd07807d..f47e39d7e95f75cc0a077112099f228e0058b49d 100644

--- a/components/autofill/core/browser/autofill_manager.cc

+++ b/components/autofill/core/browser/autofill_manager.cc

@@ -40,6 +40,7 @@

#include "components/autofill/core/browser/autofill_metrics.h"

#include "components/autofill/core/browser/autofill_profile.h"

#include "components/autofill/core/browser/autofill_type.h"

+#include "components/autofill/core/browser/country_names.h"

#include "components/autofill/core/browser/credit_card.h"

#include "components/autofill/core/browser/field_types.h"

#include "components/autofill/core/browser/form_structure.h"

@@ -129,6 +130,7 @@ AutofillManager::AutofillManager(

if (enable_download_manager == ENABLE_AUTOFILL_DOWNLOAD_MANAGER) {

download_manager_.reset(new AutofillDownloadManager(driver, this));

}

+ CountryNames::SetLocaleString(app_locale_);

}

AutofillManager::~AutofillManager() {}

@@ -1135,6 +1137,7 @@ AutofillManager::AutofillManager(AutofillDriver* driver,

weak_ptr_factory_(this) {

DCHECK(driver_);

DCHECK(client_);

+ CountryNames::SetLocaleString(app_locale_);

}

bool AutofillManager::RefreshDataModels() {