Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1582243005:
allow specific test for make check (Closed)
|
Created:
4 years, 11 months ago by rkotlerimgtec Modified:
4 years, 11 months ago CC:
native-client-reviews_googlegroups.com, rich.fuhler_imgtec.com Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master Target Ref:
refs/heads/master Visibility:
Public. |
Descriptionwith this patch you can run check-lit on a specific test.
i.e.make -f Makefile.standalone check-lit CHECK_LIT_TESTS=tests_lit/llvm2ice_tests/arith.lll
The default will be for the directory to be in subzero but
it's also possible to create an absolute pathname.
Extended this to work with cross tests.
Added some primitive help for the makefile.
make -f Makefile.standalone help
make -f Makefile.standalone help-check-lit
make -f makefile.standalone help-check-xtest
BUG=
R=stichnot@chromium.org
Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=2c3c82e26c745e8fdb8a47d6461189f0bbadaafe
Patch Set 1 #
Total comments: 1
Patch Set 2 : changes suggested by stichnot #
Total comments: 8
Patch Set 3 : changes suggested by stichnot #
Total comments: 6
Patch Set 4 : changes suggested by stichnot #Patch Set 5 : changes suggested by stichnot #
Messages
Total messages: 24 (7 generated)
Description was changed from ========== allow specific test for make check BUG= ========== to ========== with this patch you can run check-lit on a specific test. i.e. make -f Makefile.standalone check-lit TESTS_LIT=tests_lit/llvm2ice_tests/ The default will be for the directory to be in subzero but it's also possible to create an absolute pathname. I'm not very good with makefiles so I can't say whether this is the most clever way to solve this problem. BUG= ==========
rkotlerimgtec@gmail.com changed reviewers: + jpp@chromium.org, kschimpf@chromium.org, stichnot@chromium.org
On 2016/01/15 03:23:33, rkotlerimgtec wrote: Did not spend much time on this but even now wildcards would work. make -f Makefile.standalone check-lit TESTS_LIT="tests_lit/llvm2ice_tests/add*.ll" Absolute pathnames has some issues.
Description was changed from ========== with this patch you can run check-lit on a specific test. i.e. make -f Makefile.standalone check-lit TESTS_LIT=tests_lit/llvm2ice_tests/ The default will be for the directory to be in subzero but it's also possible to create an absolute pathname. I'm not very good with makefiles so I can't say whether this is the most clever way to solve this problem. BUG= ========== to ========== with this patch you can run check-lit on a specific test. i.e.make -f Makefile.standalone check-lit TESTS_LIT=/home/rkotler/testsz/64bit.pnacl.ll The default will be for the directory to be in subzero but it's also possible to create an absolute pathname. I'm not very good with makefiles so I can't say whether this is the most clever way to solve this problem. BUG= ==========
On 2016/01/15 03:30:12, rkotlerimgtec wrote: Have updated the issue description to have the correct example: make -f Makefile.standalone check-lit TESTS_LIT=/home/rkotler/testsz/64bit.pnacl.ll
I need to go home. Another mistake in description: make -f Makefile.standalone check-lit TESTS_LIT=tests_lit/llvm2ice_tests/arith.ll On Thu, Jan 14, 2016 at 7:31 PM, <rkotlerimgtec@gmail.com> wrote: > On 2016/01/15 03:30:12, rkotlerimgtec wrote: > > Have updated the issue description to have the correct example: > > make -f Makefile.standalone check-lit > TESTS_LIT=/home/rkotler/testsz/64bit.pnacl.ll > > > > https://codereview.chromium.org/1582243005/ > -- You received this message because you are subscribed to the Google Groups "Native-Client-Reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to native-client-reviews+unsubscribe@googlegroups.com. To post to this group, send email to native-client-reviews@googlegroups.com. Visit this group at https://groups.google.com/group/native-client-reviews. For more options, visit https://groups.google.com/d/optout.
Description was changed from ========== with this patch you can run check-lit on a specific test. i.e.make -f Makefile.standalone check-lit TESTS_LIT=/home/rkotler/testsz/64bit.pnacl.ll The default will be for the directory to be in subzero but it's also possible to create an absolute pathname. I'm not very good with makefiles so I can't say whether this is the most clever way to solve this problem. BUG= ========== to ========== with this patch you can run check-lit on a specific test. i.e.make -f Makefile.standalone check-lit TESTS_LIT=tests_lit/llvm2ice_tests/arith.lll The default will be for the directory to be in subzero but it's also possible to create an absolute pathname. I'm not very good with makefiles so I can't say whether this is the most clever way to solve this problem. BUG= ==========
It might be worth adding something more general for extra parameters and such to lit as is with $(FORCEASM_LIT_TEST_EXCLUDES) $(FORCEASM_LIT_PARAM) On 2016/01/15 03:32:52, rkotlerimgtec wrote: > I need to go home. Another mistake in description: > > make -f Makefile.standalone check-lit > TESTS_LIT=tests_lit/llvm2ice_tests/arith.ll > > > > On Thu, Jan 14, 2016 at 7:31 PM, <mailto:rkotlerimgtec@gmail.com> wrote: > > > On 2016/01/15 03:30:12, rkotlerimgtec wrote: > > > > Have updated the issue description to have the correct example: > > > > make -f Makefile.standalone check-lit > > TESTS_LIT=/home/rkotler/testsz/64bit.pnacl.ll > > > > > > > > https://codereview.chromium.org/1582243005/ > > > > -- > You received this message because you are subscribed to the Google Groups > "Native-Client-Reviews" group. > To unsubscribe from this group and stop receiving emails from it, send an email > to mailto:native-client-reviews+unsubscribe@googlegroups.com. > To post to this group, send email to mailto:native-client-reviews@googlegroups.com. > Visit this group at https://groups.google.com/group/native-client-reviews. > For more options, visit https://groups.google.com/d/optout.
https://codereview.chromium.org/1582243005/diff/1/Makefile.standalone File Makefile.standalone (right): https://codereview.chromium.org/1582243005/diff/1/Makefile.standalone#newcode37 Makefile.standalone:37: TESTS_LIT ?= tests_lit Currently lit is used two situations: 1. "make check-lit" where you may want to run just one test to make it easier to sift through the error spewage. 2. "make check-xtest" where you may want to run just one test because it takes several minutes to run them all. So I think two variables may be in order here. CHECK_LIT_TESTS ?= tests_lit CHECK_XTEST_TESTS ?= crosstest/Output and then make a similar modification to the check-xtest lit command. It would also be good to document the ?= assignment here with an example of a single-test override, because I know I for one will continually revisit this Makefile to remember how it's done.
Description was changed from ========== with this patch you can run check-lit on a specific test. i.e.make -f Makefile.standalone check-lit TESTS_LIT=tests_lit/llvm2ice_tests/arith.lll The default will be for the directory to be in subzero but it's also possible to create an absolute pathname. I'm not very good with makefiles so I can't say whether this is the most clever way to solve this problem. BUG= ========== to ========== with this patch you can run check-lit on a specific test. i.e.make -f Makefile.standalone check-lit CHECK_LIT_TESTS=tests_lit/llvm2ice_tests/arith.lll The default will be for the directory to be in subzero but it's also possible to create an absolute pathname. Extended this to work with cross tests. Added some primitive help for the makefile. make -f Makefile.standalone help make -f Makefile.standalone help-check-lit make -f makefile.standalone help-check-xtest BUG= ==========
https://codereview.chromium.org/1582243005/diff/20001/Makefile.standalone File Makefile.standalone (right): https://codereview.chromium.org/1582243005/diff/20001/Makefile.standalone#new... Makefile.standalone:36: # Allow tests_lit to be overidden I would make the comment a bit more verbose/helpful, e.g. # Allow tests to be overridden, e.g.: # make check-lit CHECK_LIT_TESTS="tests_lit/llvm2ice_tests/{alloc,arith}.ll" I would also like to add an example of CHECK_XTEST_TESTS, but I can't get anything to work! Did you have any luck? https://codereview.chromium.org/1582243005/diff/20001/Makefile.standalone#new... Makefile.standalone:342: help-check-lit help-check-xtest This continuation line doesn't need a tab character (though this may be moot in light of the comment below). https://codereview.chromium.org/1582243005/diff/20001/Makefile.standalone#new... Makefile.standalone:551: @echo I think this might be better accomplished by just cat'ing some help file from the docs directory, with just a single 'help' target that dumps everything. This would make it easier to update, reflow text, avoid 80-col overflow, etc.
https://codereview.chromium.org/1582243005/diff/20001/Makefile.standalone File Makefile.standalone (right): https://codereview.chromium.org/1582243005/diff/20001/Makefile.standalone#new... Makefile.standalone:36: # Allow tests_lit to be overidden On 2016/01/20 17:35:52, stichnot wrote: > I would make the comment a bit more verbose/helpful, e.g. > > # Allow tests to be overridden, e.g.: > # make check-lit CHECK_LIT_TESTS="tests_lit/llvm2ice_tests/{alloc,arith}.ll" > > I would also like to add an example of CHECK_XTEST_TESTS, but I can't get > anything to work! Did you have any luck? These are already covered in the help for the makefile. if you type : make -f Makefile.standalone help Then you get instructions for how to get further help, including examples. make -f Makefile.standalone help-check-lit make -f Makefile.standalone help-check-xtest The cross test example worked for me. https://codereview.chromium.org/1582243005/diff/20001/Makefile.standalone#new... Makefile.standalone:342: help-check-lit help-check-xtest On 2016/01/20 17:35:52, stichnot wrote: > This continuation line doesn't need a tab character (though this may be moot in > light of the comment below). Done. https://codereview.chromium.org/1582243005/diff/20001/Makefile.standalone#new... Makefile.standalone:551: @echo On 2016/01/20 17:35:52, stichnot wrote: > I think this might be better accomplished by just cat'ing some help file from > the docs directory, with just a single 'help' target that dumps everything. > This would make it easier to update, reflow text, avoid 80-col overflow, etc. Done.
Can you also adjust the Description to form a more standard git commit message? e.g. https://github.com/torvalds/subsurface/blob/master/README#L88 https://codereview.chromium.org/1582243005/diff/20001/Makefile.standalone File Makefile.standalone (right): https://codereview.chromium.org/1582243005/diff/20001/Makefile.standalone#new... Makefile.standalone:36: # Allow tests_lit to be overidden On 2016/01/21 01:48:55, rkotlerimgtec wrote: > On 2016/01/20 17:35:52, stichnot wrote: > > I would make the comment a bit more verbose/helpful, e.g. > > > > # Allow tests to be overridden, e.g.: > > # make check-lit CHECK_LIT_TESTS="tests_lit/llvm2ice_tests/{alloc,arith}.ll" > > > > I would also like to add an example of CHECK_XTEST_TESTS, but I can't get > > anything to work! Did you have any luck? > > These are already covered in the help for the makefile. > > if you type : > > make -f Makefile.standalone help > > Then you get instructions for how to get further help, including > examples. > > make -f Makefile.standalone help-check-lit > make -f Makefile.standalone help-check-xtest > > The cross test example worked for me. > > OK - but can address the first part of my comment? repeated/extended here: I would make the comment a bit more verbose/helpful, e.g. # Allow tests to be overridden, e.g.: # make -f Makefile.standalone check-lit \ # CHECK_LIT_TESTS="tests_lit/llvm2ice_tests/{alloc,arith}.ll" # make -f Makefile.standalone check-xtest \ # CHECK_XTEST_TESTS=crosstest/Output/simple_loop_x8632_native_O2_sse2.xtest https://codereview.chromium.org/1582243005/diff/40001/Makefile.standalone-hel... File Makefile.standalone-help/check-lit.txt (right): https://codereview.chromium.org/1582243005/diff/40001/Makefile.standalone-hel... Makefile.standalone-help/check-lit.txt:1: In all these .txt files, please remove leading and trailing blank lines to silence git complaints. If you want more distinct separation, either echo blank lines at a higher level, or use a line of all '----' or '====' here, or ... Also in all these .txt files, please follow the 80-col limit. https://codereview.chromium.org/1582243005/diff/40001/Makefile.standalone-hel... Makefile.standalone-help/check-lit.txt:4: to check a specific test, override CHECK_LIT_TESTS Here I would clean up capitalization, line breaks, etc.: To check a specific test, override CHECK_LIT_TESTS, e.g.: make -f Makefile.standalone check-lit \ CHECK_LIT_TESTS=tests_lit/llvm2ice_tests/arith.ll Same comment for the other .txt files. https://codereview.chromium.org/1582243005/diff/40001/Makefile.standalone-hel... File Makefile.standalone-help/help.txt (right): https://codereview.chromium.org/1582243005/diff/40001/Makefile.standalone-hel... Makefile.standalone-help/help.txt:9: makefile -f Makefile.standalone help-target . so for example: make (not makefile)
Patchset #4 (id:60001) has been deleted
https://codereview.chromium.org/1582243005/diff/20001/Makefile.standalone File Makefile.standalone (right): https://codereview.chromium.org/1582243005/diff/20001/Makefile.standalone#new... Makefile.standalone:36: # Allow tests_lit to be overidden On 2016/01/22 03:05:21, stichnot wrote: > On 2016/01/21 01:48:55, rkotlerimgtec wrote: > > On 2016/01/20 17:35:52, stichnot wrote: > > > I would make the comment a bit more verbose/helpful, e.g. > > > > > > # Allow tests to be overridden, e.g.: > > > # make check-lit > CHECK_LIT_TESTS="tests_lit/llvm2ice_tests/{alloc,arith}.ll" > > > > > > I would also like to add an example of CHECK_XTEST_TESTS, but I can't get > > > anything to work! Did you have any luck? > > > > These are already covered in the help for the makefile. > > > > if you type : > > > > make -f Makefile.standalone help > > > > Then you get instructions for how to get further help, including > > examples. > > > > make -f Makefile.standalone help-check-lit > > make -f Makefile.standalone help-check-xtest > > > > The cross test example worked for me. > > > > > > OK - but can address the first part of my comment? repeated/extended here: > > I would make the comment a bit more verbose/helpful, e.g. > > # Allow tests to be overridden, e.g.: > # make -f Makefile.standalone check-lit \ > # CHECK_LIT_TESTS="tests_lit/llvm2ice_tests/{alloc,arith}.ll" > # make -f Makefile.standalone check-xtest \ > # CHECK_XTEST_TESTS=crosstest/Output/simple_loop_x8632_native_O2_sse2.xtest Done. https://codereview.chromium.org/1582243005/diff/40001/Makefile.standalone-hel... File Makefile.standalone-help/check-lit.txt (right): https://codereview.chromium.org/1582243005/diff/40001/Makefile.standalone-hel... Makefile.standalone-help/check-lit.txt:1: On 2016/01/22 03:05:21, stichnot wrote: > In all these .txt files, please remove leading and trailing blank lines to > silence git complaints. If you want more distinct separation, either echo blank > lines at a higher level, or use a line of all '----' or '====' here, or ... > > Also in all these .txt files, please follow the 80-col limit. Done. https://codereview.chromium.org/1582243005/diff/40001/Makefile.standalone-hel... Makefile.standalone-help/check-lit.txt:4: to check a specific test, override CHECK_LIT_TESTS On 2016/01/22 03:05:21, stichnot wrote: > Here I would clean up capitalization, line breaks, etc.: > > To check a specific test, override CHECK_LIT_TESTS, e.g.: > make -f Makefile.standalone check-lit \ > CHECK_LIT_TESTS=tests_lit/llvm2ice_tests/arith.ll > > Same comment for the other .txt files. Done. https://codereview.chromium.org/1582243005/diff/40001/Makefile.standalone-hel... File Makefile.standalone-help/help.txt (right): https://codereview.chromium.org/1582243005/diff/40001/Makefile.standalone-hel... Makefile.standalone-help/help.txt:9: makefile -f Makefile.standalone help-target . so for example: On 2016/01/22 03:05:21, stichnot wrote: > make > (not makefile) Done.
On 2016/01/22 03:48:31, rkotlerimgtec wrote: > https://codereview.chromium.org/1582243005/diff/20001/Makefile.standalone > File Makefile.standalone (right): > > https://codereview.chromium.org/1582243005/diff/20001/Makefile.standalone#new... > Makefile.standalone:36: # Allow tests_lit to be overidden > On 2016/01/22 03:05:21, stichnot wrote: > > On 2016/01/21 01:48:55, rkotlerimgtec wrote: > > > On 2016/01/20 17:35:52, stichnot wrote: > > > > I would make the comment a bit more verbose/helpful, e.g. > > > > > > > > # Allow tests to be overridden, e.g.: > > > > # make check-lit > > CHECK_LIT_TESTS="tests_lit/llvm2ice_tests/{alloc,arith}.ll" > > > > > > > > I would also like to add an example of CHECK_XTEST_TESTS, but I can't get > > > > anything to work! Did you have any luck? > > > > > > These are already covered in the help for the makefile. > > > > > > if you type : > > > > > > make -f Makefile.standalone help > > > > > > Then you get instructions for how to get further help, including > > > examples. > > > > > > make -f Makefile.standalone help-check-lit > > > make -f Makefile.standalone help-check-xtest > > > > > > The cross test example worked for me. > > > > > > > > > > OK - but can address the first part of my comment? repeated/extended here: > > > > I would make the comment a bit more verbose/helpful, e.g. > > > > # Allow tests to be overridden, e.g.: > > # make -f Makefile.standalone check-lit \ > > # CHECK_LIT_TESTS="tests_lit/llvm2ice_tests/{alloc,arith}.ll" > > # make -f Makefile.standalone check-xtest \ > > # > CHECK_XTEST_TESTS=crosstest/Output/simple_loop_x8632_native_O2_sse2.xtest > > Done. > > https://codereview.chromium.org/1582243005/diff/40001/Makefile.standalone-hel... > File Makefile.standalone-help/check-lit.txt (right): > > https://codereview.chromium.org/1582243005/diff/40001/Makefile.standalone-hel... > Makefile.standalone-help/check-lit.txt:1: > On 2016/01/22 03:05:21, stichnot wrote: > > In all these .txt files, please remove leading and trailing blank lines to > > silence git complaints. If you want more distinct separation, either echo > blank > > lines at a higher level, or use a line of all '----' or '====' here, or ... > > > > Also in all these .txt files, please follow the 80-col limit. > > Done. > > https://codereview.chromium.org/1582243005/diff/40001/Makefile.standalone-hel... > Makefile.standalone-help/check-lit.txt:4: to check a specific test, override > CHECK_LIT_TESTS > On 2016/01/22 03:05:21, stichnot wrote: > > Here I would clean up capitalization, line breaks, etc.: > > > > To check a specific test, override CHECK_LIT_TESTS, e.g.: > > make -f Makefile.standalone check-lit \ > > CHECK_LIT_TESTS=tests_lit/llvm2ice_tests/arith.ll > > > > Same comment for the other .txt files. > > Done. > > https://codereview.chromium.org/1582243005/diff/40001/Makefile.standalone-hel... > File Makefile.standalone-help/help.txt (right): > > https://codereview.chromium.org/1582243005/diff/40001/Makefile.standalone-hel... > Makefile.standalone-help/help.txt:9: makefile -f Makefile.standalone help-target > . so for example: > On 2016/01/22 03:05:21, stichnot wrote: > > make > > (not makefile) > > Done. I think I messed up the patch history here a bit. I forget to save something and thought I had already done a git cl upload so I deleted patch 4 accidentially.
Not sure exactly what I did here that messed up the patch history. I'm rushing to leave out of town and I think what happened is that I accidentally added the python script doxypypy to my local master branch. Sorry about this. If you need me to do anything here, please ask. On Thu, Jan 21, 2016 at 7:51 PM, <rkotlerimgtec@gmail.com> wrote: > On 2016/01/22 03:48:31, rkotlerimgtec wrote: > >> https://codereview.chromium.org/1582243005/diff/20001/Makefile.standalone >> File Makefile.standalone (right): >> > > > > https://codereview.chromium.org/1582243005/diff/20001/Makefile.standalone#new... > >> Makefile.standalone:36: # Allow tests_lit to be overidden >> On 2016/01/22 03:05:21, stichnot wrote: >> > On 2016/01/21 01:48:55, rkotlerimgtec wrote: >> > > On 2016/01/20 17:35:52, stichnot wrote: >> > > > I would make the comment a bit more verbose/helpful, e.g. >> > > > >> > > > # Allow tests to be overridden, e.g.: >> > > > # make check-lit >> > CHECK_LIT_TESTS="tests_lit/llvm2ice_tests/{alloc,arith}.ll" >> > > > >> > > > I would also like to add an example of CHECK_XTEST_TESTS, but I >> can't >> > get > >> > > > anything to work! Did you have any luck? >> > > >> > > These are already covered in the help for the makefile. >> > > >> > > if you type : >> > > >> > > make -f Makefile.standalone help >> > > >> > > Then you get instructions for how to get further help, including >> > > examples. >> > > >> > > make -f Makefile.standalone help-check-lit >> > > make -f Makefile.standalone help-check-xtest >> > > >> > > The cross test example worked for me. >> > > >> > > >> > >> > OK - but can address the first part of my comment? repeated/extended >> here: >> > >> > I would make the comment a bit more verbose/helpful, e.g. >> > >> > # Allow tests to be overridden, e.g.: >> > # make -f Makefile.standalone check-lit \ >> > # CHECK_LIT_TESTS="tests_lit/llvm2ice_tests/{alloc,arith}.ll" >> > # make -f Makefile.standalone check-xtest \ >> > # >> CHECK_XTEST_TESTS=crosstest/Output/simple_loop_x8632_native_O2_sse2.xtest >> > > Done. >> > > > > https://codereview.chromium.org/1582243005/diff/40001/Makefile.standalone-hel... > >> File Makefile.standalone-help/check-lit.txt (right): >> > > > > https://codereview.chromium.org/1582243005/diff/40001/Makefile.standalone-hel... > >> Makefile.standalone-help/check-lit.txt:1: >> On 2016/01/22 03:05:21, stichnot wrote: >> > In all these .txt files, please remove leading and trailing blank lines >> to >> > silence git complaints. If you want more distinct separation, either >> echo >> blank >> > lines at a higher level, or use a line of all '----' or '====' here, or >> ... >> > >> > Also in all these .txt files, please follow the 80-col limit. >> > > Done. >> > > > > https://codereview.chromium.org/1582243005/diff/40001/Makefile.standalone-hel... > >> Makefile.standalone-help/check-lit.txt:4: to check a specific test, >> override >> CHECK_LIT_TESTS >> On 2016/01/22 03:05:21, stichnot wrote: >> > Here I would clean up capitalization, line breaks, etc.: >> > >> > To check a specific test, override CHECK_LIT_TESTS, e.g.: >> > make -f Makefile.standalone check-lit \ >> > CHECK_LIT_TESTS=tests_lit/llvm2ice_tests/arith.ll >> > >> > Same comment for the other .txt files. >> > > Done. >> > > > > https://codereview.chromium.org/1582243005/diff/40001/Makefile.standalone-hel... > >> File Makefile.standalone-help/help.txt (right): >> > > > > https://codereview.chromium.org/1582243005/diff/40001/Makefile.standalone-hel... > >> Makefile.standalone-help/help.txt:9: makefile -f Makefile.standalone >> > help-target > >> . so for example: >> On 2016/01/22 03:05:21, stichnot wrote: >> > make >> > (not makefile) >> > > Done. >> > > I think I messed up the patch history here a bit. I forget to save > something and > thought I had already done a git cl upload so I deleted patch 4 > accidentially. > > > https://codereview.chromium.org/1582243005/ > -- You received this message because you are subscribed to the Google Groups "Native-Client-Reviews" group. To unsubscribe from this group and stop receiving emails from it, send an email to native-client-reviews+unsubscribe@googlegroups.com. To post to this group, send email to native-client-reviews@googlegroups.com. Visit this group at https://groups.google.com/group/native-client-reviews. For more options, visit https://groups.google.com/d/optout.
Fixed this mistake of adding another patch.
lgtm
Description was changed from ========== with this patch you can run check-lit on a specific test. i.e.make -f Makefile.standalone check-lit CHECK_LIT_TESTS=tests_lit/llvm2ice_tests/arith.lll The default will be for the directory to be in subzero but it's also possible to create an absolute pathname. Extended this to work with cross tests. Added some primitive help for the makefile. make -f Makefile.standalone help make -f Makefile.standalone help-check-lit make -f makefile.standalone help-check-xtest BUG= ========== to ========== with this patch you can run check-lit on a specific test. i.e.make -f Makefile.standalone check-lit CHECK_LIT_TESTS=tests_lit/llvm2ice_tests/arith.lll The default will be for the directory to be in subzero but it's also possible to create an absolute pathname. Extended this to work with cross tests. Added some primitive help for the makefile. make -f Makefile.standalone help make -f Makefile.standalone help-check-lit make -f makefile.standalone help-check-xtest BUG= R=stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a... ==========
Message was sent while issue was closed.
Committed patchset #5 (id:100001) manually as 2c3c82e26c745e8fdb8a47d6461189f0bbadaafe (presubmit successful). |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
