Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 158223002: Part 5 of search provider refactoring. (Closed)

Created:
6 years, 10 months ago by Maria
Modified:
6 years, 10 months ago
Reviewers:
H Fung, msw
CC:
chromium-reviews, James Su, Mark P
Visibility:
Public.

Description

Part 5 of search provider refactoring. Factor out a shared Stop() method into superclass. The method is public because AutocompleteController calls Stop() on zero_suggest_provider. There is no change to functionality. BUG=338955 TBR=mpearson Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=251746

Patch Set 1 #

Patch Set 2 : Fix up virtual keywords #

Patch Set 3 : Rebase #

Patch Set 4 : Co-locate overrides #

Total comments: 2

Patch Set 5 : Switch to pre-increment #

Patch Set 6 : Rebase + fix indentation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -78 lines) Patch
M chrome/browser/autocomplete/base_search_provider.h View 1 2 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/autocomplete/base_search_provider.cc View 1 2 3 4 5 2 chunks +38 lines, -30 lines 0 comments Download
M chrome/browser/autocomplete/search_provider.h View 1 2 3 3 chunks +2 lines, -8 lines 0 comments Download
M chrome/browser/autocomplete/search_provider.cc View 1 2 3 4 3 chunks +17 lines, -25 lines 0 comments Download
M chrome/browser/autocomplete/zero_suggest_provider.h View 1 2 3 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/autocomplete/zero_suggest_provider.cc View 1 2 3 4 5 2 chunks +14 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Maria
This one should be easier than part 4 :)
6 years, 10 months ago (2014-02-13 23:41:36 UTC) #1
H Fung
lgtm https://codereview.chromium.org/158223002/diff/80001/chrome/browser/autocomplete/search_provider.cc File chrome/browser/autocomplete/search_provider.cc (right): https://codereview.chromium.org/158223002/diff/80001/chrome/browser/autocomplete/search_provider.cc#newcode491 chrome/browser/autocomplete/search_provider.cc:491: for (int i = 0; i < suggest_results_pending_; ...
6 years, 10 months ago (2014-02-14 00:43:07 UTC) #2
Maria
https://codereview.chromium.org/158223002/diff/80001/chrome/browser/autocomplete/search_provider.cc File chrome/browser/autocomplete/search_provider.cc (right): https://codereview.chromium.org/158223002/diff/80001/chrome/browser/autocomplete/search_provider.cc#newcode491 chrome/browser/autocomplete/search_provider.cc:491: for (int i = 0; i < suggest_results_pending_; i++) ...
6 years, 10 months ago (2014-02-14 02:37:29 UTC) #3
msw
lgtm
6 years, 10 months ago (2014-02-17 08:30:06 UTC) #4
Maria
The CQ bit was checked by mariakhomenko@chromium.org
6 years, 10 months ago (2014-02-18 06:41:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mariakhomenko@chromium.org/158223002/180001
6 years, 10 months ago (2014-02-18 06:42:07 UTC) #6
commit-bot: I haz the power
6 years, 10 months ago (2014-02-18 08:26:37 UTC) #7
Message was sent while issue was closed. 
Change committed as 251746

Powered by Google App Engine
This is Rietveld 408576698