Implements intrinsics for ARM.

runtime/vm/flow_graph_compiler_arm.cc

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/globals.h"  // Needed here to get TARGET_ARCH_ARM.
 #if defined(TARGET_ARCH_ARM)
 
 #include "vm/flow_graph_compiler.h"
 
 #include "lib/error.h"
@@ skipping 1496 matching lines @@
                                               FpuRegister right,
                                               Register result) {
   UNIMPLEMENTED();
 }
 
 
 FieldAddress FlowGraphCompiler::ElementAddressForIntIndex(intptr_t cid,
                                                           intptr_t index_scale,
                                                           Register array,
                                                           intptr_t index) {
-  UNIMPLEMENTED();
-  return FieldAddress(array, index);
+  const int64_t disp =
+      static_cast<int64_t>(index) * index_scale + DataOffsetFor(cid);
+  ASSERT(Utils::IsAbsoluteUint(12, disp));

[regis, 2013/05/28 22:01:44]

This assert will fire sooner or later.
I do not think we should implement this ElementAddressForIntIndex function on
ARM, because the range is too limited. It should be marked as UNREACHABLE like
ElementAddressForRegIndex below.
It is better to inline this function as needed (as is
ElementAddressForRegIndex).  

[zra, 2013/05/28 22:49:31]

Done.

+  return FieldAddress(array, static_cast<int32_t>(disp));
 }
 
 
 FieldAddress FlowGraphCompiler::ElementAddressForRegIndex(intptr_t cid,
                                                           intptr_t index_scale,
                                                           Register array,
                                                           Register index) {
   UNREACHABLE();  // No register indexed with offset addressing mode on ARM.
   return FieldAddress(array, index);
 }
@@ skipping 199 matching lines @@
 void ParallelMoveResolver::RestoreFpuScratch(FpuRegister reg) {
   __ vldrd(reg, Address(SP, kDoubleSize, Address::PostIndex));
 }
 
 
 #undef __
 
 }  // namespace dart
 
 #endif  // defined TARGET_ARCH_ARM